Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTimePicker): update to v3 #18153

Merged
merged 29 commits into from
Mar 26, 2024
Merged

feat(VTimePicker): update to v3 #18153

merged 29 commits into from
Mar 26, 2024

Conversation

blalan05
Copy link
Member

@blalan05 blalan05 commented Aug 26, 2023

<template>
  <v-app>
    <v-main>
      <v-container>
        <v-row>
          {{ thisDate }}
          <v-col>
            <v-switch v-model="format24" label="24hr" false-value="ampm" true-value="24hr" color="primary" />
          </v-col>
          <v-col>
            <v-switch v-model="seconds" label="Seconds" />
          </v-col>
          <v-col>
            <v-switch v-model="actions" label="No Actions" />
          </v-col>
        </v-row>
        <v-row>
          <v-col cols="12">
            <v-time-picker v-model="thisDate" :format="format24" :use-seconds="seconds" :hide-actions="actions" />
          </v-col>
        </v-row>
        <v-row>
          <v-col>
            <v-date-picker />
          </v-col>
        </v-row>
      </v-container>
    </v-main>
  </v-app>
</template>
<script setup>
  import { ref } from 'vue'

  const thisDate = ref(new Date())

  const format24 = ref('24hr')
  const seconds = ref(false)

  const actions = ref(false)
</script>

@blalan05 blalan05 self-assigned this Aug 26, 2023
@johnleider johnleider changed the title feat(VTimePicker): Update to v3 feat(VTimePicker): update to v3 Aug 29, 2023
@blalan05 blalan05 force-pushed the feat/v3-time-picker-labs branch from 8d1ee5b to 97581a2 Compare October 24, 2023 20:39
@blalan05 blalan05 changed the base branch from dev to master October 27, 2023 20:04
@blalan05 blalan05 force-pushed the feat/v3-time-picker-labs branch from befca67 to 142cd64 Compare October 28, 2023 04:28
@nekosaur
Copy link
Member

I think this needs to be rebased? Seems like a lot of unrelated commits have snuck in

@blalan05 blalan05 force-pushed the feat/v3-time-picker-labs branch from 142cd64 to a64c01c Compare October 28, 2023 13:48
@blalan05
Copy link
Member Author

I think this needs to be rebased? Seems like a lot of unrelated commits have snuck in

Done.

@blalan05 blalan05 marked this pull request as ready for review October 30, 2023 16:50
@AngeloACR
Copy link

So is there any plan to make this production ready in the near future?

@johnleider
Copy link
Member

What do you think?

@blalan05 blalan05 linked an issue Dec 12, 2023 that may be closed by this pull request
@johnleider johnleider force-pushed the master branch 8 times, most recently from 7cd11a6 to d0765f1 Compare December 17, 2023 01:32
@johnleider johnleider force-pushed the feat/v3-time-picker-labs branch from 5449f0f to 5032265 Compare March 25, 2024 14:17
@johnleider johnleider force-pushed the feat/v3-time-picker-labs branch from cbdb3fb to 8617106 Compare March 26, 2024 16:06
@johnleider johnleider force-pushed the feat/v3-time-picker-labs branch from 8617106 to af3407e Compare March 26, 2024 16:09
@johnleider johnleider added this to the v3.8.0 (Andromeda) milestone Mar 26, 2024
@johnleider johnleider merged commit 695f5f4 into master Mar 26, 2024
13 checks passed
@johnleider johnleider deleted the feat/v3-time-picker-labs branch March 26, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] v-timepicker
8 participants