Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 #182

Merged
merged 6 commits into from
Feb 20, 2019
Merged

0.5.0 #182

merged 6 commits into from
Feb 20, 2019

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Feb 11, 2019

This comes after #181.

After merge @Hoverbear will publish.

Instead of waiting for #101 and some pending PRs, we'll roll those out in 0.6.0.

The reason for accelerating this release is that the client-rust CI fails on stable with Clippy due to our use of feature(). There may be other downstreams affected, so we're releasing this soon with this fix to help that problem.

@Hoverbear Hoverbear added this to the 0.5.0 milestone Feb 11, 2019
@Hoverbear Hoverbear self-assigned this Feb 11, 2019
@Hoverbear Hoverbear requested review from brson and hicqu February 11, 2019 19:11
brson
brson previously approved these changes Feb 11, 2019
Copy link

@brson brson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu
Copy link
Contributor

hicqu commented Feb 14, 2019

LGTM.

hicqu
hicqu previously approved these changes Feb 14, 2019
@Hoverbear Hoverbear dismissed stale reviews from hicqu and brson via 6ef8c0b February 14, 2019 17:01
@Hoverbear
Copy link
Contributor Author

I updated it to include joint consensus #101 . :) @hicqu and @brson PTAL again.

@Hoverbear Hoverbear requested review from brson and hicqu February 14, 2019 17:02
brson
brson previously requested changes Feb 15, 2019
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear Hoverbear added the Do Not Merge A blocked PR. Please do not merge it. label Feb 15, 2019
@Hoverbear
Copy link
Contributor Author

Blocked on #181

@Hoverbear
Copy link
Contributor Author

@brson PTAL, added joint consensus change.

@Hoverbear Hoverbear removed the Do Not Merge A blocked PR. Please do not merge it. label Feb 19, 2019
@Hoverbear Hoverbear mentioned this pull request Feb 19, 2019
7 tasks
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hicqu hicqu merged commit aa51593 into master Feb 20, 2019
@Hoverbear Hoverbear deleted the version-0.5.0 branch February 20, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants