Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README and some lib.rs docs #31

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Add README and some lib.rs docs #31

merged 3 commits into from
Feb 15, 2019

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Feb 12, 2019 •
edited by brson
Loading

This adds a first pass of README and the crate level docs.

Edit (brson): Rendered README

@Hoverbear Hoverbear self-assigned this Feb 12, 2019
@Hoverbear Hoverbear requested review from brson and QueenyJin February 12, 2019 00:50
@QueenyJin
Copy link

@dcalvin PTAL.

@QueenyJin QueenyJin requested a review from dcalvin February 12, 2019 02:18
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
dcalvin
dcalvin reviewed Feb 12, 2019
View reviewed changes
@Hoverbear Hoverbear force-pushed the readme-and-lib-docs branch 2 times, most recently from 750c7a6 to 43fa973 Compare February 12, 2019 19:13
brson
brson requested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@brson brson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please answer my questions and resolve my comments as you see fit, and I'll approve.

@Hoverbear Hoverbear removed the request for review from QueenyJin February 13, 2019 21:13
dcalvin
dcalvin approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear requested a review from brson February 14, 2019 17:20
@Hoverbear Hoverbear mentioned this pull request Feb 14, 2019
Closed
3 tasks
@brson
Copy link
Contributor

brson commented Feb 15, 2019

Needs sign off, but it's good to merge after.

@Hoverbear
Add README and some lib.rs docs
249dd97 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Apply suggestions from code review
9d9b2cc 
Nit fixes.

Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Nit fixes
104509f 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Copy link
Contributor Author

Merging, CI still red.

@Hoverbear Hoverbear merged commit a5a6b15 into master Feb 15, 2019
@ice1000
Copy link

ice1000 commented Feb 15, 2019

I believe CI is failing due to the organization transfer.

@Hoverbear
Copy link
Contributor Author

@ice1000 The CI is failing because of the recent kvproto update as well as the need for a recent raft release. :(

pingcap/kvproto#354
pingcap/kvproto#355
tikv/raft-rs#182

@ice1000
Copy link

ice1000 commented Feb 15, 2019

Wooo. So the badge's URL in README need to be updated.

@sticnarf sticnarf deleted the readme-and-lib-docs branch April 7, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brson brson brson approved these changes

@dcalvin dcalvin dcalvin approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hoverbear @QueenyJin @brson @ice1000 @dcalvin