Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nebula beta driver #2

Closed
wants to merge 59 commits into from
Closed

Nebula beta driver #2

wants to merge 59 commits into from

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Mar 1, 2022

PR Type

  • New Feature

Related Links

https://tier4.atlassian.net/browse/T4PUB-464

Description

An initial Working beta version of Nebula Driver with support for Hesai's and Velodyne sensors

Review Procedure

ros2 launch nebula_lidar_driver hesai.xml sensor_model:=Pandar64

ros2 launch nebula_lidar_driver hesai.xml sensor_model:=Pandar40P

ros2 launch nebula_lidar_driver hesai.xml sensor_model:=PandarQT64

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to a reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

h-mitsui-esol and others added 30 commits May 27, 2021 10:59
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
* add colcon build env. (base code is 0624e)

* move some hpp files, add src folder in livox driver

* trivial modification

* Update README.md

* remove unneccesary files

* remove unneccesary header

* move third-party source files

* update code(20210630)

* Delete different test files.

* README.md add "4. running"

* README crlf

* HwInterface/udp_socket.hpp

* modify for ros2 run error

* Update README.md

* accumulate_count

* time_stamp

* struct LivoxPointXyzrtl packed

* GetEchoNumPerPoint()

* cloud.width 24000

* time_base -> time_stamp

* code fix

* cloud.width update

* code fix

* code fix

* StreamStart retry 30sec

* code fix

* rviz2

* fix format

* <br>

* format ros2wrapper

* frame_id

* frame_id

* Update README.md

* Update README.md

* discussion_r664993039

* typo typo brief and only English in the comments. and LivoxDataCallback delete

* PI -> M_PI

* Revert "PI -> M_PI"

This reverts commit c54bbe3b3c1954f82247d38570bdf71a3ddf38b6.

* PI -> M_PI 2nd

* thread pointer -> shared_ptr

* modify CMakelists.txt and package.xml to using ament_cmake_auto

* README.md

* default node name

* add composable node (#4)

* add composable node

* fix conflicts

* fix exec node

* change sensor name fix to variable

* fix can use ros2_wrapper_main.cpp

* README.md

* default node name

* change namespace

* add namespace to topic names

Co-authored-by: mitui.hide <h-mitsui@esol.co.jp>

* package.xml maintainer and README.md

* #discussion_r666683800

* #discussion_r666712110

* #discussion_r665125337

* #discussion_r664995104

* #discussion_r666078326

* #discussion_r665121366

* #discussion_r665121366 Expansion

* typedef enum -> enum

* typedef enum -> enum

* #discussion_r665121708

* #discussion_r665124279

* #discussion_r664995791

* typo #discussion_r670300391

* #discussion_r664987903

* Revert "#discussion_r664987903"

This reverts commit 97d78e64c13e5bb59b98bd1f17f1bfd527384852.

* #discussion_r664987903

* #discussion_r664988302

* #discussion_r664989270

* #discussion_r664989004

* CMakeList.txt remove(-g -O0)

* smart_pointers. #issuecomment-878771481

Co-authored-by: mitui.hide <h-mitsui@esol.co.jp>
Co-authored-by: v-nagai7872@esol.co.jp <v-nagai7872@esol.co.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
* add colcon build env. (base code is 0624e)

* move some hpp files, add src folder in livox driver

* trivial modification

* Update README.md

* remove unneccesary files

* remove unneccesary header

* move third-party source files

* update code(20210630)

* Delete different test files.

* README.md add "4. running"

* README crlf

* HwInterface/udp_socket.hpp

* modify for ros2 run error

* Update README.md

* accumulate_count

* time_stamp

* struct LivoxPointXyzrtl packed

* GetEchoNumPerPoint()

* cloud.width 24000

* time_base -> time_stamp

* code fix

* cloud.width update

* code fix

* code fix

* StreamStart retry 30sec

* code fix

* rviz2

* fix format

* <br>

* format ros2wrapper

* frame_id

* frame_id

* Update README.md

* Update README.md

* discussion_r664993039

* typo typo brief and only English in the comments. and LivoxDataCallback delete

* PI -> M_PI

* Revert "PI -> M_PI"

This reverts commit c54bbe3b3c1954f82247d38570bdf71a3ddf38b6.

* PI -> M_PI 2nd

* thread pointer -> shared_ptr

* modify CMakelists.txt and package.xml to using ament_cmake_auto

* README.md

* default node name

* add composable node (#4)

* add composable node

* fix conflicts

* fix exec node

* change sensor name fix to variable

* fix can use ros2_wrapper_main.cpp

* README.md

* default node name

* change namespace

* add namespace to topic names

Co-authored-by: mitui.hide <h-mitsui@esol.co.jp>

* package.xml maintainer and README.md

* #discussion_r666683800

* #discussion_r666712110

* #discussion_r665125337

* #discussion_r664995104

* #discussion_r666078326

* #discussion_r665121366

* #discussion_r665121366 Expansion

* typedef enum -> enum

* typedef enum -> enum

* #discussion_r665121708

* #discussion_r665124279

* #discussion_r664995791

* esol_ReviewNo6

* esol_ReviewNo26

* esol_ReviewNo24

* Revert "esol_ReviewNo24"

This reverts commit 0e8f33341186d6fa4a905de45c8f9aa28b8d29cb.

* Revert "esol_ReviewNo24"

This reverts commit 0e8f33341186d6fa4a905de45c8f9aa28b8d29cb.

* esol_ReviewNo24

* esol_ReviewNo27

* esol_ReviewNo17

* format

* esol_ReviewNo21

* develop #1 6bae863876bfda52db848ed31e415a3b16a0b6a8

* tab -> space

* develop marge

* CMakeLists.txt remove(-g -O0)

* T4PUB-358 1st

* format and bug-fix

* 5#discussion_r677475332

* Add comment semaphore_

* 5#discussion_r678802453

Co-authored-by: mitui.hide <h-mitsui@esol.co.jp>
Co-authored-by: v-nagai7872@esol.co.jp <v-nagai7872@esol.co.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: h-mitsui-esol <57085544+h-mitsui-esol@users.noreply.github.com>
* Refactor 1st

* pull/6#discussion_r681704754

* pull/6#discussion_r682172984

* pull/6#discussion_r681705368

* pull/6#discussion_r680921593 and pull/6#discussion_r680922194

* pull/6#discussion_r681711654

* 6#discussion_r682170555
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* Refactor 1st

* pull/6#discussion_r681704754

* pull/6#discussion_r682172984

* pull/6#discussion_r681705368

* pull/6#discussion_r680921593 and pull/6#discussion_r680922194

* pull/6#discussion_r681711654

* 6#discussion_r682170555

* livox_driver utest 1st

* T4PUB-437 bug fix.

* Fix merge failure 3371552e395f1817adb3a32ea9f95360d72019f8

* pull/9#discussion_r689167375 and pull/9#discussion_r689204716
* Livox Diagnostics. Initial non working commit

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* clang. add tier4 format

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* gitignore. Add Tier4 ignore file

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* wip

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* wip 2

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* code adaptations to new main branch

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* wip 3 get device status from sensor

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* adaptations for diagnostics from eth packet

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* RosWrapper. parse and report Diagnostics

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* lidar_driver. fix getcommandid switch

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* ros2_driver_wrapper. fix switch indent

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* git workflow. test CI token

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* livox_command. Remove unused CommandPushAbnormalState struct

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* add fallthroughts

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* apply t4 formatting

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* livox_diagnostics. remove unnecessary code for boolean vars

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* ros2_driver_wrapper. clarify level comparison with enum

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* livox_diagnostics. remove unncessary comma at the end of enum

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* ros2_driver_wrapper. group diagnostics members

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* gitignore. remove aw related entries

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* ros2_driver_wrapper. simplify ros diagnostics string

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* revert fallthroughs on switch

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* replace shift logic for bit fields

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* add private keyword to clarify

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* separate diagnostics, remove static definition

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* add missing StatusCodeToLivoxMotorStatus

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* Separate diagnostics to multiple reports

Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>

* update status from sensor

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* wrapper. remove the namespace from the diagnostic task

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>

* ros2_wrapper. remove unncessary lidar_identifier

Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
jacoblambert and others added 3 commits February 16, 2022 02:31
Update README.md

See merge request perceptionengine/pe-drivers/nebula_driver!5
@aohsato
Copy link
Collaborator

aohsato commented Mar 1, 2022

@amc-nu

An initial Working beta version of Nebula Driver with support for Hesai's sensors

Velodyne too?

@aohsato aohsato requested review from aohsato, 0x126 and drwnz March 1, 2022 10:44
@amc-nu
Copy link
Contributor Author

amc-nu commented Mar 1, 2022

Yes! Velodyne supported

amc-nu and others added 15 commits May 19, 2022 03:03
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: PE <abraham.monrroy@tier4.jp>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
fix: prevent build error from logger parenthesis
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
@amc-nu
Copy link
Contributor Author

amc-nu commented Jan 30, 2023

Closing due to deprecation, moved to #10

@amc-nu amc-nu closed this Jan 30, 2023
@amc-nu amc-nu deleted the nebula branch January 30, 2023 06:17
wep21 added a commit that referenced this pull request Mar 7, 2023
* ci: add sync files

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
wep21 added a commit that referenced this pull request Mar 7, 2023
* ci: add sync files (#2)

* ci: add sync files

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Update .github/sync-files.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#3)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* ci: update workflow (#1)

* ci: update ci config

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: apply pre-commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci: update workflow

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update .pre-commit-config.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: add empty repos (#4)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: sync files (#5)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#6)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#7)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#9)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#10)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#11)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: sync files (#12)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: sync files (#13)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: sync files (#15)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: sync files (#16)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#17)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: sync files (#18)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#19)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#20)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#21)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#22)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#23)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#24)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#25)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#27)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#28)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#29)

Signed-off-by: GitHub <noreply@github.com>

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#30)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* remove legacy ci

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* update isort

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

---------

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants