rebase pull or so? #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works just like `SI`, except it uses prefixes for kilo- and milli-.
Hide SI prefix for 10^n if |n| <= minexponent
- Standard (original) behavior: sort on values - new *sort* option to disable sorting
This works only if the global opacity is also specified and <1. To blend different surfaces, an opacity of 0.99 works great.
This reverts commit b9dad67.
This reverts commit 89e1342.
Disable text selection
reuse pie.sort in attributes, default true
satisfy eslint
Add `minexponent` attribute to control usage of SI prefixes in axis ticks
Handle colorscale with transparent colors in surface traces
- obey npm lint - add sort option to treemap (define attribute & coerce in default Treepad is using the calc from sunburst, so the 1 line code change for sunburst impacted treemap (sort was not true)
Make sunburst and treemap sort optional
bump tinycolor2 v1.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your interest in plotly.js!
Translations:
lib/locales/, not those indist/Features, Bug fixes, and others:
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
Before opening a pull request, developer should:
git rebasetheir local branch off the latestmaster,git addthedist/folder (thedist/is updated only on version bumps),package-lock.jsonfile (if any),Note that it is forbidden to force push (i.e.
git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, pleasegit merge masterinto your PR branch instead ofgit rebase master.