Add minexponent attribute to control usage of SI prefixes in axis ticks

[ignamv]

Resolves #5111

Presently, SI prefixes are not used for powers of 10 smaller than 3 (no prefixes for 10^-3, 10^-2, ..., 10^3).

The new minexponent attribute defaults to 3, which matches the current behavior. By setting it to 0, one can force the usage of SI prefixes for all powers of 10 (including 1m, 10m, ..., 1k). By setting it to a large value, one can disable SI prefixes up to a certain value (using plain numbers instead).

@plotly/plotly_js

[archmoj]

@ignamv could you please investigate why the test image fails for these mocks?

contour_edge_cases
contour_label-thousands-suffix
funnel_axis_textangle
funnel_axis_textangle_outside
funnel_axis_textangle_start-end
gl2d_parcoords
gl2d_parcoords_2
gl2d_parcoords_large

[ignamv]

Sure, I'll see if I can run the image tests locally.

[ignamv]

Haven't managed to run them locally yet. These are the 4 failing images, animated to show the difference. The text wiggles 1 pixel to the left/right.

[ignamv]

Is it possible that the failure is not related to my changes? I see the exact same failing tests in the master branch:

https://app.circleci.com/pipelines/github/plotly/plotly.js/1206/workflows/138b256c-8dae-4215-81de-e9a22ad14b84/jobs/86606

[archmoj]

Is it possible that the failure is not related to my changes? I see the exact same failing tests in the master branch:

https://app.circleci.com/pipelines/github/plotly/plotly.js/1206/workflows/138b256c-8dae-4215-81de-e9a22ad14b84/jobs/86606

Yes it is possible. But strangely today I was not able to rerun the workflow of this branch on the CircleCI!

[ignamv]

Hi, I was wondering if there's something left to do on my end.

[archmoj]

Hi, I was wondering if there's something left to do on my end.

@ignamv
Thanks for the follow up. I noticed the colorbar needs an extra line after

minexponent: opts.minexponent

right after https://github.com/ignamv/plotly.js/blob/d90b39b3c7ef377bb57a9e06b7316ed524cdf807/src/components/colorbar/draw.js#L685

[archmoj]

There are still a few comments on this PR which are not resolved.
@ignamv are you interested in finishing this PR?
FYI - a new minor may be released next week where we could potentially include this new feature.

[archmoj]

Nicely done.
💃

[ignamv]

Thanks! But what about the failing tests?

[archmoj]

Thanks! But what about the failing tests?

For some strange reason, I was not able to re-run your workplace on CI. Also CI was very unstable during the past day.
But please don't worry. I am actually running the tests locally to see if this may cause a problem.