Fix initialisation ordering of AppContext #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `initialiseInstanceAddress()` was called before `LOG` and `DEFAULT_INSTANCE_ADDRESS` were initialised, but relied on both of them, so threw an NPE instead of correctly assigning the default and starting up. Fixes thelastpickle#654
|
Thanks for the contribution @treuherz ! The patch as is won't build because it breaks our code style, specifically the 'Declaration Order' rule: I will put a fix based on your work in. |
|
merged with 534f5aa |
|
Appreciate the quick response. My IDE was misconfigured and the checks didn't run when I thought they had, apologies for that. It looks like it might have been that same DeclarationOrder inspection that led to this bug in the first place, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
initialiseInstanceAddress()was called beforeLOGandDEFAULT_INSTANCE_ADDRESSwere initialised, but relied on both of them, so threw an NPE instead of correctly assigning the default and starting up.Fixes #654