Exception in AppContext init throws NPE

[treuherz]

When AppContext initialises, it has some exception handling if it's unable to determine a host address.

cassandra-reaper/src/server/src/main/java/io/cassandrareaper/AppContext.java

Lines 53 to 62 in d7d045f

	private static String initialiseInstanceAddress() {
	String reaperInstanceAddress;
	try {
	reaperInstanceAddress = InetAddress.getLocalHost().getHostAddress();
	} catch (UnknownHostException e) {
	LOG.warn("Cannot get instance address", e);
	reaperInstanceAddress = DEFAULT_INSTANCE_ADDRESS;
	}
	return reaperInstanceAddress;
	}

I'm getting a NullPointerException on Line 58, which I think is because, above...

cassandra-reaper/src/server/src/main/java/io/cassandrareaper/AppContext.java

Lines 40 to 43 in d7d045f

	public static final String REAPER_INSTANCE_ADDRESS = initialiseInstanceAddress();
	private static final String DEFAULT_INSTANCE_ADDRESS = "127.0.0.1";
	private static final Logger LOG = LoggerFactory.getLogger(AppContext.class);

the logger isn't initialised till after this function runs.

I may have misunderstood what's going on here, but this seems like a simple oversight in the ordering. Happy to submit a PR to fix if you agree on the cause, but not sure how best to set up a test case.

[adejanovski]

oh wow, that is silly 😅

Totally agree on the cause and happy to take that PR. Not sure how to test this either though...