Pick up the latest knative/pkg and K8s 0.17.x #2846
Conversation
tekton-robot
added
the
do-not-merge/hold
|
/kind cleanup |
tekton-robot
added
kind/cleanup
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
The following is the coverage report on the affected files.
|
mattmoor
force-pushed
the
update-pkg-genleader
branch
from
f34c55c to
b856129
Compare
|
ah the good old |
mattmoor
force-pushed
the
update-pkg-genleader
branch
from
b856129 to
6275ac3
Compare
|
/retest |
First time I see those log on a failure of the kaniko e2e test 🤔 👀 |
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
|
/retest |
|
@vdemeester passing now! |
|
Does this mean that we would not rely on k8s 0.17.x? |
I don't think so. @mattmoor might correct me but this is just an update of the client, we are not using anything k8s 1.17 specific that wouldn't be supported earlier, right ? |
|
/hold |
|
@vdemeester @afrittoli Sorry, good catch. Too focused on genreconciler. This DOES pick up a new minimum K8s version as well: 1.16, sorry for missing that. This will enable Tekton to pick up CRD v1 🤩 , and is available on all of the public clouds, but I should have caught it. My bad. I can update the release notes, but LMK if that's cool. I put a |
|
release notes update would be good, also tho we have some docs that talk about the min version, there's definitely https://github.com/tektoncd/pipeline/blob/e68c62700da03f407e5b5376d4bf69d473900a7b/DEVELOPMENT.md#kubernetes-cluster and there might be something at https://tekton.dev/ as well (hopefully its something pulled from this repo but not sure) |
|
Thanks @bobcatfish I will circle back this afternoon and at least try to hit those places (and release notes). |
|
/hold cancel Ok, this is RFAL. I updated every 1.15 reference outside of vendor 😉 |
tekton-robot
removed
the
do-not-merge/hold
|
/retest |
|
I feel like we should discuss with with a larger audience before moving forward? @mattmoor do you think it would be possible to control this via a feature flag? What I mean, if I'm not interested in scaling in the controller horizontally, be able to run on k8s 1.15. |
|
@afrittoli Generally the hard version dependency check is configurable via an environment variable on the controller, but I believe we also picked up some use of the v1 CRD API, which is only available in 1.16+ Note that our K8s minimum version principle is based on what K8s actually supports upstream, but Ack the massive lag most cloud providers have here. We are actually late picking up 1.16 because GKE was so far behind. Ack the broader discussion, should I start one in slack? |
|
At least, let's hold that for after 0.14 (aka requiring 1.16 as minimum) ? |
|
@vdemeester When is that? Is there a regular cycle? Happy to mark it on my calendar to circle back and rebase/update. |
|
@mattmoor it's almost a regular cycle. It should happen next week (thursday 🙏) |
|
@vdemeester ok, great. By then we should have pkg 0.16 snapped (Tuesday), so I will plan to update this shortly thereafter, and then it will hopefully just be good-to-go when the snap has happened. |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
The only other manual changes are: 1. Call `Promote` in tests, otherwise our generated reconcilers won't do anything (they aren't the leader!) 2. Fill in namespaces in a few tests (I believe this is a change in the k8s 0.17.x libs) The main change with respect to genreconciler is that they will now generate LeaderAware reconcilers. Reconcilers may be sharded across multiple replicas by setting the `buckets` in `config-leaderelection`, which will subdivide the key space being reconciled across N buckets, which are individually leader elected. The broader design for this is here: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit#
mattmoor
force-pushed
the
update-pkg-genleader
branch
from
3a5c062 to
6d39ed0
Compare
mattmoor
force-pushed
the
update-pkg-genleader
branch
from
c4e214f to
13e3a50
Compare
|
@vdemeester Ok, I think this is ready to go once the release cuts, it pins to |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
Thanks @vdemeester 🤩 @afrittoli @bobcatfish LMK if there's anything else? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
The only other manual changes are:
Promotein tests, otherwise our generated reconcilers won't do anything (they aren't the leader!)The main change with respect to genreconciler is that they will now generate LeaderAware reconcilers. Reconcilers may be sharded across multiple replicas by setting the
bucketsinconfig-leaderelection, which will subdivide the key space being reconciled across N buckets, which are individually leader elected.Right now the sharded reconcilers only light up through our webhook entrypoint in shared main, but I hope to eliminate the split (likely through having mirrored entrypoints for a time) in the near future.
The broader design for this is here: https://docs.google.com/document/d/1i_QHjQO2T3SNv49xjZLWlivcc0UvZN1Tbw2NKxThkyM/edit
/hold
cc @vdemeester @imjasonh