Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Auto-update dependencies #2572

Closed
wants to merge 1 commit into from
Closed

[master] Auto-update dependencies #2572

wants to merge 1 commit into from

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented May 7, 2020

Produced via:
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
/assign ImJasonH vdemeester
/cc ImJasonH vdemeester

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 7, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2020
@tekton-robot
Copy link
Collaborator

Hi @mattmoor. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli afrittoli added the kind/misc Categorizes issue or PR as a miscellaneuous one. label May 8, 2020
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch 5 times, most recently from b9845da to e7bca7d Compare May 14, 2020 14:33
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch 7 times, most recently from 1f4e75f to 361a59c Compare May 22, 2020 14:20
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch 3 times, most recently from a2da355 to 48dac4b Compare May 27, 2020 14:24
@jlpettersson
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
@jlpettersson jlpettersson mentioned this pull request Jun 1, 2020
Merged
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch from 48dac4b to 4d51e67 Compare June 2, 2020 14:19
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2020
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch from 4d51e67 to 342de4a Compare June 3, 2020 14:20
@vdemeester
Copy link
Member

@mattmoor hum, why the only changes are on the third_party folder 🤔 (and none on go.sum, go.mod, …)

@mattmoor
[master] Auto-update dependencies
5b5a1e1 
Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign ImJasonH vdemeester
/cc ImJasonH vdemeester
@mattmoor mattmoor force-pushed the dep-update-tektoncd-pipeline-jjlhc-pod-48dkm branch from 342de4a to 5b5a1e1 Compare June 12, 2020 14:20
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2020
@mattmoor
Copy link
Member Author

@vdemeester sorry I filter most of these mails, so I didn't see your comment. I see changes to go.*, but I'd guess there were differences when you looked because someone didn't run things properly and it made it into HEAD?

@vdemeester
Copy link
Member

@mattmoor that's what's worrying me a bit… it should have shown in the CI (if those file were missing in a PR)… This might mean we have a bad check somewhere 😝

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@vdemeester
Copy link
Member

/cc @bobcatfish @afrittoli @sbwsg @dibyom
@mattmoor might conflict with #2846 but is independent right ?

@tekton-robot tekton-robot requested review from afrittoli, bobcatfish, dibyom and a user June 24, 2020 11:12
@mattmoor
Copy link
Member Author

@vdemeester I really like the check we have here: https://github.com/vmware-tanzu/sources-for-knative/blob/master/.github/workflows/go-verify.yml

@mattmoor
Copy link
Member Author

Also, yes it will conflict :)

@mattmoor mattmoor closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

@afrittoli afrittoli Awaiting requested review from afrittoli

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @tekton-robot @jlpettersson @vdemeester @imjasonh @afrittoli