Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI #928

Merged
merged 1 commit into from
May 7, 2023
Merged

Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/containers/App/__snapshots__/App.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ exports[`App should render the component correctly and match the snapshot 1`] =
<header role={[undefined]} className=\\"pf-c-page__header\\">
<div className=\\"pf-c-page__header-brand\\">
<a className=\\"pf-c-page__header-brand-link\\">
<Brand src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE setno CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" onClick={[Function: homePage]}>
<img onClick={[Function: homePage]} className=\\"pf-c-brand\\" src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE setno CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" />
<Brand src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" onClick={[Function: homePage]}>
<img onClick={[Function: homePage]} className=\\"pf-c-brand\\" src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" />
</Brand>
</a>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/containers/Header/__snapshots__/Header.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ exports[`Header should render the header component and find Search component 1`]
<header role={[undefined]} className=\\"pf-c-page__header\\">
<div className=\\"pf-c-page__header-brand\\">
<a className=\\"pf-c-page__header-brand-link\\">
<Brand src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE setno CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" onClick={[Function: homePage]}>
<img onClick={[Function: homePage]} className=\\"pf-c-brand\\" src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE setno CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" />
<Brand src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" onClick={[Function: homePage]}>
<img onClick={[Function: homePage]} className=\\"pf-c-brand\\" src=\\"data:no CUSTOM_LOGO_MEDIA_TYPE set;base64,no CUSTOM_LOGO_BASE64_URI set\\" alt=\\"Tekton Hub Logo\\" />
</Brand>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/containers/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const Header: React.FC = observer(() => {
CUSTOM_LOGO_BASE64_DATA != ''
? `data:${
CUSTOM_LOGO_MEDIA_TYPE != '' ? CUSTOM_LOGO_MEDIA_TYPE : 'image/png'
}${CUSTOM_LOGO_MEDIA_TYPE};base64,${CUSTOM_LOGO_BASE64_DATA}`
};base64,${CUSTOM_LOGO_BASE64_DATA}`
: logo
}
alt="Tekton Hub Logo"
Expand Down