Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI #928

Merged
merged 1 commit into from
May 7, 2023
Merged

Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI #928

merged 1 commit into from
May 7, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Apr 14, 2023 •
edited
Loading

This patch will remove duplicaion of
CUSTOM_LOGO_MEDIA_TYPE in logo src

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

Release Notes

Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI

@pratap0007
Remove duplication of CUSTOM_LOGO_MEDIA_TYPE in UI
ee239ed 
This patch will remove duplicaion of
CUSTOM_LOGO_MEDIA_TYPE in logo src

Signed-off-by: Shiv Verma <shverma@redhat.com>
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2023
@pratap0007
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2023
@tekton-robot tekton-robot merged commit 646e71f into tektoncd:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa approved these changes

@vinamra28 vinamra28 vinamra28 approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@sm43 sm43 Awaiting requested review from sm43

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pratap0007 @tekton-robot @piyush-garg @jkandasa @vinamra28