Pull latest release #1253
Merged
Pull latest release #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I hope.) Also, re-enable test, and add new one for loading from scratch. The savedState files are different on different OSes because the size of things is different (notably 'unsigned long').
The test seems to work in some contexts but not others. Committing this version so we can test it on python on other platforms.
The trick turned out to be that on linux, loading loadBinary into jit->compiledModuleBinaryStream corrupted the compiledModuleBinaryStream. Instead, we now convert to and from a string, and that seems to work. At the same time, I changed the factory to return Jit* objects instead of unique_ptr objects, which also seems to work, though that might be a purely cosmetic change.
Also, bugs appeared only after loading twice, so check that.
Because this changes the save file format slightly.
* Move string conversion of compiledModuleBinaryStream to Jit class itself. * Remove spurious endl. * Initialize all object children in ModelGeneratorContext's default constructor. * Clean up Jit objects in factory test. * Describe new state_saving test and how to fix it when it inevitably breaks.
Fix for issue #1210
- it now runs on macos machines with Apple Silicon chips - gcc is now updated in all linux platforms - Host architecture is no longer provided in the matrix and is extracted internally - artifacts names now provide more info about the machine and the compiler they were built on
Convert to the new GITHUB_OUTPUT instead. Might not work with 'message'; could need to use 'echo' instead?
In theory, we'll need to update to node20 soon; this gets us partway there, and also sets up some python things.
Hopefully should work with node20? Might need v4 for that. Relative paths don't work, cf actions/upload-artifact#176
(No llvm for it.)
Without this i am getting `'uint32_t' is not a member of 'std'`. See also https://gcc.gnu.org/gcc-13/porting_to.html "Header dependency changes".
fix: compile error with gcc13
…which no steady state is reached.
…pdated (the issue with nleq2 is addressed in the new version of libroadrunner-deps)
…o that it considers the condition in which no steady state is reached.
…plugins) - Identified and corrected memory leaks in using RRStringArrayPtr, RRCDataPtr, and RRVectorPtr. - Implemented unique_ptr for RRVector.
…erent-results-on-mac-m1s Fixing the issue with getting different results on mac m1s
Move to numpy 2 and Python 3.13
…ak_of_auto2000_plugin fix: resolve memory leaks in auto2000 plugin
Update getFullJacobian, getReducedJacobian to handle reactions between species in different compartments of differing volumes. Affects getEigenValues() results.
* Use MacOS13 * Use latest dependencies. * Fix installed swig 4.2 on ubuntu 24.
Fix workflow.
Fix jacobian
Update numpy
(But also update the savedState_windows.rr file, since I could update that one.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.