Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The documentation says that relative paths are allowed, but they aren’t #176

Open
2 of 6 tasks
leafac opened this issue Feb 15, 2021 · 8 comments
Open
2 of 6 tasks

The documentation says that relative paths are allowed, but they aren’t #176

leafac opened this issue Feb 15, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@leafac
Copy link

leafac commented Feb 15, 2021 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

Compare the documentation:

Relative and absolute file paths are both allowed.

To what actually happens:

  with:
    path: ../courselore.zip
Error: Invalid pattern '../courselore.zip'. Relative pathing '.' and '..' is not allowed.

Version

  • V1
  • V2

Environment

  • self-hosted
  • Linux
  • Windows
  • Mac

Screenshots
If applicable, add screenshots to help explain your problem.

Run/Repo Url
If applicable, and if your repo/run is public, please include a URL so it is easier for us to investigate.

How to reproduce
If applicable, add information on how to reproduce the problem.

Additional context
Add any other context about the problem here.
@leafac leafac added the bug Something isn't working label Feb 15, 2021
@hannesa2
Copy link

Same here

      - name: Upload
        uses: actions/upload-artifact@v2.2.3
        with: 
          name: ios_dist.tgz
          path: ../viro/ios/dist/

shows me

image

@flavienbwk
Copy link

Same problem for me.

@jjhartmann
Copy link

I'm running into this error as well.

@o01eg
Copy link

o01eg commented Oct 7, 2022

Would be nice if it will be fixed.

RadxaYuntian added a commit to radxa-pkg/rockchip-iqfiles that referenced this issue Dec 30, 2022
@RadxaYuntian
Workaround actions/upload-artifact#176
2e42bd2
@RadxaYuntian
Copy link

Currently I have to use the following workaround to upload Debian package, which is created in parent folder by default:

      - name: Workaround actions/upload-artifact#176
        run: |
          echo "artifacts_path=$(realpath ..)" >> $GITHUB_ENV
      - name: Upload artifacts
        uses: actions/upload-artifact@v3
        with:
          name: ${{ github.event.repository.name }}
          path: |
            ${{ env.artifacts_path }}/*.deb

RealOrangeOne added a commit to sourcebots/runusb that referenced this issue Jul 1, 2023
@RealOrangeOne
Get debian package name as separate step
4ee3127 
Works around actions/upload-artifact#176
@id88
Copy link

id88 commented Oct 10, 2023

That's too bad. Why hasn't it been fixed yet

@kireerik kireerik mentioned this issue Dec 16, 2023
Open
@wanosoft
Copy link

Same here!

datalogics-saharay added a commit to datalogics-saharay/apdfl-csharp-dotnet-samples that referenced this issue Mar 13, 2024
@datalogics-saharay
Try to add a workaround for archiving sample output in parent dir
4e19b83 
- The upload-artifact action supposedly supports relative paths, but
  it threw an error when relative paths were used. There also seems to
  be a few open bugs reported on GitHub, here's one: actions/upload-artifact#176.

- Since some of the samples dump their output in the parent directory, let's
  try a workaround to see if we can archive them in the workflow run.
datalogics-saharay added a commit to datalogics-saharay/apdfl-csharp-dotnet-samples that referenced this issue Mar 13, 2024
@datalogics-saharay
Try to add a workaround for archiving sample output in parent dir
c4c3950 
- The upload-artifact action supposedly supports relative paths, but
  it threw an error when relative paths were used. There also seems to
  be a few open bugs reported on GitHub, here's one: actions/upload-artifact#176.

- Since some of the samples dump their output in the parent directory, let's
  try a workaround to see if we can archive them in the workflow run.
joverlee521 added a commit to nextstrain/.github that referenced this issue Mar 15, 2024
@joverlee521
pathogen-repo-build: Move build.log outside of working directory
0c2d300 
The entire working directory gets zipped and uploaded to AWS Batch when
using the `aws-batch` runtime, which includes an early `build.log` file.
When the build completes and downloads the build outputs, the early
`build.log` file overwrites the local `build.log` of the GH Action.
This results in a truncated file that does not include the
AWS_BATCH_JOB_ID and prevents the generation of the AWS Batch summary.

This commit moves the hard-coded `build.log` file to outside of the
current working directory to prevent it from being uploaded with the
pathogen repo build.

Using "~/build.log" because "../build.log" is not allowed as a pattern
for the `upload-artifact`` action.¹

¹ actions/upload-artifact#176
joverlee521 added a commit to nextstrain/.github that referenced this issue Mar 15, 2024
@joverlee521
pathogen-repo-build: Move build.log to ignored directory
504728b 
The entire working directory gets zipped and uploaded to AWS Batch when
using the `aws-batch` runtime, which includes an early `build.log` file.
When the build completes and downloads the build outputs, the early
`build.log` overwrites the local `build.log` of the GH Action.
This results in a truncated file that does not include the
AWS_BATCH_JOB_ID and prevents the generation of the AWS Batch summary.

This commit moves the hard-coded `build.log` file to an ignored directory
(the same directory that we are using for the nextstrain/.github repo¹).
This prevents the `build.log` from being uploaded with the build.

Previously tried other paths, but they all caused errors.
- "../build.log" - ".." pattern is not allowed for the `upload-artifact` action²
- "~/build.log" - `hashfiles` requires files to be in the `GITHUB_WORKSPACE`³

¹ #44 (comment)
² actions/upload-artifact#176
³ https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles
joverlee521 added a commit to nextstrain/.github that referenced this issue Mar 15, 2024
@joverlee521
pathogen-repo-build: Move build.log to ignored directory
5c5a528 
The entire working directory gets zipped and uploaded to AWS Batch when
using the `aws-batch` runtime, which includes an early `build.log` file.
When the build completes and downloads the build outputs, the early
`build.log` overwrites the local `build.log` of the GH Action.
This results in a truncated file that does not include the
AWS_BATCH_JOB_ID and prevents the generation of the AWS Batch summary.

This commit moves the hard-coded `build.log` file to an ignored directory
(the same directory that we are using for the nextstrain/.github repo¹).
This prevents the `build.log` from being uploaded with the build.

Previously tried other paths, but they all caused errors.
- "../build.log" - ".." pattern is not allowed for the `upload-artifact` action²
- "~/build.log" - `hashfiles` requires files to be in the `GITHUB_WORKSPACE`³

¹ #44 (comment)
² actions/upload-artifact#176
³ https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles
joverlee521 added a commit to nextstrain/.github that referenced this issue Mar 15, 2024
@joverlee521
pathogen-repo-build: Move build.log to ignored directory
df165a8 
The entire working directory gets zipped and uploaded to AWS Batch when
using the `aws-batch` runtime, which includes an early `build.log` file.
When the build completes and downloads the build outputs, the early
`build.log` overwrites the local `build.log` of the GH Action.
This results in a truncated file that does not include the
AWS_BATCH_JOB_ID and prevents the generation of the AWS Batch summary
and the re-attachment to the AWS Batch job in subsequent `wait` jobs.

This commit moves the hard-coded `build.log` file to an ignored directory
(the same directory that we are using for the nextstrain/.github repo¹).
This prevents the `build.log` from being uploaded with the build.

Previously tried other paths, but they all caused errors.
- "../build.log" - ".." pattern is not allowed for the `upload-artifact` action²
- "~/build.log" - `hashfiles` requires files to be in the `GITHUB_WORKSPACE`³

¹ #44 (comment)
² actions/upload-artifact#176
³ https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles
sebastianczech added a commit to PaloAltoNetworks/pan-os-codegen that referenced this issue Mar 25, 2024
@sebastianczech
Workaround actions/upload-artifact#176
025754c
luciansmith added a commit to sys-bio/roadrunner that referenced this issue May 10, 2024
@luciansmith
Try to use upload-artifacts v3
2226aef 
Hopefully should work with node20?  Might need v4 for that.  Relative paths don't work, cf actions/upload-artifact#176
remarkablemark added a commit to remarkablegames/psych-101 that referenced this issue Jul 1, 2024
@remarkablemark
ci(github): remove upload-artifact from workflow build.yml
89cb0e9 
```
Error: Invalid pattern '../dist'. Relative pathing '.' and '..' is not allowed.
```

actions/upload-artifact#176
haichangsi added a commit to haichangsi/distributed-ranges that referenced this issue Jul 15, 2024
@haichangsi
upload deb workaround
079f290 
due to actions/upload-artifact#176
haichangsi added a commit to haichangsi/distributed-ranges that referenced this issue Jul 16, 2024
@haichangsi
upload deb workaround
86570bd 
due to actions/upload-artifact#176
agottardo added a commit to tailscale/go that referenced this issue Sep 12, 2024
@agottardo @mpminardi
github: bump artifact actions version
eec79ce 
Update .github/workflows/build.yml to use v4s of the upload-artifact and download-artifact actions. Adds a workaround for actions/upload-artifact#176.

Co-authored-by: Mario Minardi <mminardi@shaw.ca>
@agottardo agottardo mentioned this issue Sep 12, 2024
Merged
agottardo added a commit to tailscale/go that referenced this issue Sep 12, 2024
@agottardo @mpminardi
github: bump artifact actions version
34af900 
Update .github/workflows/build.yml to use v4s of the upload-artifact and download-artifact actions. Adds a workaround for actions/upload-artifact#176. Adds a dependabot check for outdated GitHub Actions.

Co-authored-by: Mario Minardi <mminardi@shaw.ca>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 12, 2024
@agottardo @mpminardi @bradfitz
github: bump artifact actions version
b8e4270 
Update .github/workflows/build.yml to use v4s of the upload-artifact
and download-artifact actions. Adds a workaround for
actions/upload-artifact#176. Adds a dependabot check for outdated
GitHub Actions.

Co-authored-by: Mario Minardi <mminardi@shaw.ca>
@joeyparrish
Copy link

This seems to go deeper than just upload-artifact. It relies on @actions/glob, which is where this restriction comes from.

It seems like a thing we should be able to fix there, but I'm not sure if the maintainers would accept the change.

vmcj added a commit to vmcj/upload-artifact that referenced this issue Mar 9, 2025
@vmcj
Document relative paths not working
907c586 
Multiple users can't get relative paths to work (see: actions#176). It would be great if relative paths do work but documenting the current case is better and reverting when this is fixed/(re-)implemented.
@vmcj vmcj mentioned this issue Mar 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@o01eg @leafac @hannesa2 @jjhartmann @joeyparrish @flavienbwk @wanosoft @id88 @RadxaYuntian