Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #38 by differentiating src/index.js file #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hamirmahal
Copy link
Contributor

This pull request closes #38 if we merge it.

It adds some comments to src/index.js so people going through the tutorial on their own don't edit the wrong index.js file for the first task.

Copy link
Owner

@sveinpg sveinpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add some information about how to view changes in this file?

This is meant as a playground

@hamirmahal
Copy link
Contributor Author

Ah, I see. When I was working through the tutorial I was mostly trying to pass the tests, and I didn't really get around to using this file as a playground too much, so I'm not really 100 percent sure how to view the changes one would make in this file. Definitely feel free to make changes to this pull request as you see fit.

@hamirmahal hamirmahal requested a review from sveinpg March 20, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should src/index.js have a comment saying to update the other src/index.js for the first task?
2 participants