Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should src/index.js have a comment saying to update the other src/index.js for the first task? #38

Open
hamirmahal opened this issue Mar 13, 2021 · 0 comments · May be fixed by #39
Open

Should src/index.js have a comment saying to update the other src/index.js for the first task? #38

hamirmahal opened this issue Mar 13, 2021 · 0 comments · May be fixed by #39

Comments

@hamirmahal
Copy link
Contributor

My first pass through this tutorial I spent a lot of time editing src/index.js without seeing results.

That's because I was actually supposed to modify src/react/index.js instead of src/index.js.

I think it might be helpful to add a comment in src/index.js to let people know that it's not the correct file to edit for the first task.

I have a fix for this locally for which I can create a pull request.
hamirmahal added a commit to hamirmahal/build-your-own-react that referenced this issue Mar 14, 2021
@hamirmahal
close sveinpg#38 by differentiating src/index.js file
e4639de
@hamirmahal hamirmahal linked a pull request Mar 14, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

close #38 by differentiating src/index.js file hamirmahal/build-your-own-react
1 participant
@hamirmahal