Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/general tidy up #88

Merged
merged 26 commits into from
Mar 1, 2021
Merged

Conversation

mst101
Copy link
Contributor

@mst101 mst101 commented Feb 12, 2021

Notable changes:

  • Improve the naming of some variables e.g. open/close
  • Have a data property called view from which the picker computed property (previously named currentPicker) can be derived
  • Emit set-view events with a view parameter as opposed to emitting change-month-calendar or change-year-calendar
  • Rename picker components to PickerDay, PickerMonth and PickerYear
  • Tweak some tests to improve coverage

@mst101 mst101 mentioned this pull request Feb 12, 2021
@mst101 mst101 force-pushed the refactor/general-tidy-up branch from 2777049 to 3075dac Compare February 15, 2021 21:22
@mst101
Copy link
Contributor Author

mst101 commented Feb 16, 2021

N.B. In case the last couple of commits need more explanation, please read this.

@MrWook MrWook added the enhancement New feature or request label Feb 16, 2021
@MrWook
Copy link
Collaborator

MrWook commented Feb 16, 2021

Looks awsome to me. If you resolve the conflicts and don't have anything else we can merge it

@mst101 mst101 force-pushed the refactor/general-tidy-up branch from 3075dac to 6faf027 Compare February 16, 2021 15:54
@mst101
Copy link
Contributor Author

mst101 commented Feb 16, 2021

Ok thanks. I think this will do, for now...

@mst101
Copy link
Contributor Author

mst101 commented Feb 17, 2021

@MrWook - Actually, on second thoughts, there is probably a bit more refactoring that we can/should do before tackling the keyboard navigation. I'm thinking:

  • Renaming days / months / years to cells
  • Renaming changeMonth / changeYear / changeDecade to changePage (as you have done in your keyboard navigation POC)
  • Maybe some other things too?

Let me have a go at this today...

@mst101 mst101 force-pushed the refactor/general-tidy-up branch from 6faf027 to b093435 Compare February 19, 2021 01:08
@mst101
Copy link
Contributor Author

mst101 commented Feb 19, 2021

@MrWook - ok, I think I'm done with the tidy-up. Please see what you make of it. Cheers.

@MrWook MrWook merged commit c77ed24 into sumcumo:master Mar 1, 2021
@mst101 mst101 deleted the refactor/general-tidy-up branch March 2, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants