-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/general tidy up #88
Conversation
2777049
to
3075dac
Compare
N.B. In case the last couple of commits need more explanation, please read this. |
Looks awsome to me. If you resolve the conflicts and don't have anything else we can merge it |
3075dac
to
6faf027
Compare
Ok thanks. I think this will do, for now... |
@MrWook - Actually, on second thoughts, there is probably a bit more refactoring that we can/should do before tackling the keyboard navigation. I'm thinking:
Let me have a go at this today... |
6faf027
to
b093435
Compare
@MrWook - ok, I think I'm done with the tidy-up. Please see what you make of it. Cheers. |
Notable changes:
view
from which thepicker
computed property (previously namedcurrentPicker
) can be derivedset-view
events with aview
parameter as opposed to emittingchange-month-calendar
orchange-year-calendar
PickerDay
,PickerMonth
andPickerYear