Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap focus #87

Closed
wants to merge 7 commits into from
Closed

Trap focus #87

wants to merge 7 commits into from

Conversation

betweenbrain
Copy link

  • Adds support closing the popup with the escape key
  • Implements focus trapping when the calendar button is used to open the popup

Please note that much of this depends on #81 as focus trapping is an element of keyboard accessibility.

@mst101
Copy link
Contributor

mst101 commented Feb 12, 2021

Hi @betweenbrain - thanks for your excellent suggestion of using focus trapping and for sharing the vanilla JS code.

If you check out my latest 'WIP' commit in #81 from a few days ago, you'll see I've pretty much got it working, but there's still some tidying up to do. I'll have a go at this over the weekend, but I wanted to put in a PR (#88) for some more general housekeeping first.

BTW - I like the way you break up your commits into small bite sized chunks, so I've been copying your style!

@betweenbrain
Copy link
Author

Hello @mst101!

Hi @betweenbrain - thanks for your excellent suggestion of using focus trapping and for sharing the vanilla JS code.

You're very welcome, I'm glad that it's helpful.

If you check out my latest 'WIP' commit in #81 from a few days ago, you'll see I've pretty much got it working...

That's great. To confirm, are you saying that you are implementing focus trapping as part of #81, and that this PR could be closed?

BTW - I like the way you break up your commits into small bite sized chunks, so I've been copying your style!

Awesome, thanks!

@MrWook
Copy link
Collaborator

MrWook commented Jan 20, 2022

Was done in #81

@MrWook MrWook closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants