Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Element em should not make text content bold #14290

Merged
merged 1 commit into from
Mar 22, 2021
Merged

UI: Element em should not make text content bold #14290

merged 1 commit into from
Mar 22, 2021

Conversation

Tomastomaslol
Copy link
Member

Issue: #14155

What I did

  • Do not make em bold in lib/theming/src/global.ts
  • Set strong as bold
  • Added scenario bold and emphasized text to DocumentFormattingSample and DocumentWrapper

How to test

Before change

Screen Shot 2021-03-21 at 1 41 01 pm

After change

Screen Shot 2021-03-21 at 1 14 15 pm

@Tomastomaslol Tomastomaslol linked an issue Mar 21, 2021 that may be closed by this pull request
<em> element (or _italic_) in Controls table should not be "bold" #14155
Closed
shilman
shilman approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tomastomaslol !!! 🙏

@shilman shilman changed the title UI: element em should not make text content bold UI: Element em should not make text content bold Mar 22, 2021
@shilman shilman merged commit 1527d66 into storybookjs:next Mar 22, 2021
@shilman shilman mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
bug theming ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<em> element (or _italic_) in Controls table should not be "bold"
2 participants
@Tomastomaslol @shilman