Skip to content

<em> element (or _italic_) in Controls table should not be "bold" #14155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabiradi opened this issue Mar 5, 2021 · 1 comment · Fixed by #14290
Closed

<em> element (or _italic_) in Controls table should not be "bold" #14155

fabiradi opened this issue Mar 5, 2021 · 1 comment · Fixed by #14290

Comments

@fabiradi
Copy link
Contributor

fabiradi commented Mar 5, 2021

The global style defines the HTML elements b and em both as being bold, which is not quite correct.
See

fontWeight: typography.weight.bold

As written on MDN: <em>: The Emphasis element:

Typically this element is displayed in italic type.

The problem is: If you want to use italic in the Controls table, you simply cannot. It will turn bold italic. You can also use plain bold, but that may be "too much" in some cases.

@fabiradi fabiradi changed the title em element in Controls table should not be "bold" <em> element (or _italic_) in Controls table should not be "bold" Mar 5, 2021
@Tomastomaslol Tomastomaslol linked a pull request Mar 21, 2021 that will close this issue
@shilman
Copy link
Member

shilman commented Mar 22, 2021

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-rc.7 containing PR #14290 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants