Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*ks: correctly define cluster:node_cpu:ratio rule #1520

Conversation

jacobbaungard
Copy link
Contributor

There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters.

Upstream fix was here:
prometheus-operator/kube-prometheus#1628

There was a bug in the rule imported from kube-prometheus causing the
rule not to correctly return any results. This caused the data to be
missing on the optimized dashboard from *ks clusters.

Upstream fix was here:
prometheus-operator/kube-prometheus#1628

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Copy link

sonarqubecloud bot commented Jul 1, 2024

@jacobbaungard
Copy link
Contributor Author

/test e2e-kind

Copy link

openshift-ci bot commented Jul 1, 2024

@jacobbaungard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 21b62ad link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@thibaultmg thibaultmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,thibaultmg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobbaungard
Copy link
Contributor Author

/cherrypick release-2.10

@openshift-cherrypick-robot
Copy link
Collaborator

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jacobbaungard jacobbaungard merged commit b61e755 into stolostron:main Jul 1, 2024
14 of 16 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@jacobbaungard: new pull request created: #1521

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

thibaultmg pushed a commit to thibaultmg/multicluster-observability-operator that referenced this pull request Jul 10, 2024
There was a bug in the rule imported from kube-prometheus causing the
rule not to correctly return any results. This caused the data to be
missing on the optimized dashboard from *ks clusters.

Upstream fix was here:
prometheus-operator/kube-prometheus#1628

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants