fix cluster:node_cpu:ratio query #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
lgtm
This should also close the similar PR #1504 which was never followed up on after my comment
|
Hi, Anything pending to get this merged. Thanks. |
|
Sorry for taking this long! |
5 tasks
jacobbaungard
added a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
Jul 1, 2024
There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters. Upstream fix was here: prometheus-operator/kube-prometheus#1628 Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
jacobbaungard
added a commit
to stolostron/multicluster-observability-operator
that referenced
this pull request
Jul 1, 2024
There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters. Upstream fix was here: prometheus-operator/kube-prometheus#1628 Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/multicluster-observability-operator
that referenced
this pull request
Jul 1, 2024
There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters. Upstream fix was here: prometheus-operator/kube-prometheus#1628 Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/multicluster-observability-operator
that referenced
this pull request
Jul 3, 2024
There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters. Upstream fix was here: prometheus-operator/kube-prometheus#1628 Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com> Co-authored-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
thibaultmg
pushed a commit
to thibaultmg/multicluster-observability-operator
that referenced
this pull request
Jul 10, 2024
There was a bug in the rule imported from kube-prometheus causing the rule not to correctly return any results. This caused the data to be missing on the optimized dashboard from *ks clusters. Upstream fix was here: prometheus-operator/kube-prometheus#1628 Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cluster:node_cpu:ratioquery expression was referring to an non-existent metric, could have been a typo.Also, once this is merged, planning to use
cluster:node_cpu:ratioin the cluster resource usage dashboards here as the current query there is slower to evaluate on clusters having many nodes with multi-core cpus ( cores >= 64 ).cc @paulfantom
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.