fix(ConnectDAppModal): add scrolling #15847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wrap the contents into a scroll view and don't hardcode the height Fixes #15592
Jenkins Builds
|
Seitseman
approved these changes
Jul 29, 2024
| @@ -93,56 +91,64 @@ StatusDialog { | |||
| signal disconnect() | |||
|
|
|||
| width: 480 | |||
| implicitHeight: !d.connectionAttempted ? 633 : 681 | |||
There was a problem hiding this comment.
Based on ConnectING UI and ConnectED UI
maybe it would make sense to leave implicitHeight with those values as is?
There was a problem hiding this comment.
No, no hardcoded popup heights; this allows the popup to freely shrink and grow (within the margins limits)
|
Should it be merged into 2.30 release branch? |
Yeah, created the backport PR: #15854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #15592
Affected areas
ConnectDAppModal
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-07-29.10-43-51.webm