Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dApp - sd-6 - Unable to read full contents of connection request dialog #15592

Closed
glitchminer opened this issue Jul 15, 2024 · 2 comments · Fixed by #15847
Closed

dApp - sd-6 - Unable to read full contents of connection request dialog #15592

glitchminer opened this issue Jul 15, 2024 · 2 comments · Fixed by #15847
Assignees
@caybro
Labels
bug Something isn't working dapp-interactions
Milestone
2.30.0 Beta

Comments

@glitchminer
Copy link
Contributor

Bug Report

Description

Unable to scroll to info on dApp access on the Connection request dialog

image

Steps to reproduce

Open connection request dialog with reduced window height.

Expected behavior

Scroll to dApp access info.

Additional Information

  • Status desktop version: Master, dApp flag
  • Operating System: Mac
@glitchminer glitchminer added bug Something isn't working dapp-interactions labels Jul 15, 2024
@glitchminer glitchminer added this to the 2.30.0 Beta milestone Jul 15, 2024
@Seitseman Seitseman moved this to In Progress in Status Desktop/Mobile Board Jul 22, 2024
@noeliaSD noeliaSD assigned caybro and unassigned Seitseman Jul 23, 2024
@noeliaSD noeliaSD moved this from In Progress to Iteration Backlog in Status Desktop/Mobile Board Jul 23, 2024
@caybro
Copy link
Member

caybro commented Jul 23, 2024

@Seitseman did you already start working on this? I see there's a branch created already... CC @noeliaSD

@Seitseman
Copy link
Contributor

@caybro, I've only created a branch and checked storybook on this and switched to other issue.

@caybro caybro moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jul 29, 2024
caybro added a commit that referenced this issue Jul 29, 2024
@caybro
fix(ConnectDAppModal): add scrolling
100c048 
- wrap the contents into a scroll view and don't hardcode the height

Fixes #15592
@caybro caybro mentioned this issue Jul 29, 2024
Merged
1 task
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Jul 29, 2024
@caybro caybro closed this as completed in 0e0b264 Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jul 29, 2024
caybro added a commit that referenced this issue Jul 29, 2024
@caybro
fix(ConnectDAppModal): add scrolling
cc6b5b4 
- wrap the contents into a scroll view and don't hardcode the height

Fixes #15592
@caybro caybro mentioned this issue Jul 29, 2024
Merged
jrainville pushed a commit that referenced this issue Jul 29, 2024
@caybro
fix(ConnectDAppModal): add scrolling (#15854)
deaaeeb 
- wrap the contents into a scroll view and don't hardcode the height

Fixes #15592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working dapp-interactions
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0 Beta
4 participants
@Seitseman @caybro @glitchminer @noeliaSD