Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set missing message verification and confirmation for message sent enabled by default #15774

Merged
merged 1 commit into from
Jul 29, 2024
Merged

chore: set missing message verification and confirmation for message sent enabled by default #15774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/app_service/service/accounts/dto/create_account_request.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ type

wakuV2Nameserver*: Option[string]
wakuV2LightClient*: bool
wakuV2EnableStoreConfirmationForMessagesSent*: bool
wakuV2EnableMissingMessageVerification*: bool
Comment on lines +24 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richard-ramos I think you missed to add these fields to toJson function below 🙁


logLevel*: Option[string]
logFilePath*: string
Expand Down
2 changes: 2 additions & 0 deletions src/app_service/service/accounts/service.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ QtObject:
emoji: self.defaultWalletEmoji,
logLevel: some(toStatusGoSupportedLogLevel(main_constants.LOG_LEVEL)),
wakuV2LightClient: false,
wakuV2EnableMissingMessageVerification: true,
wakuV2EnableStoreConfirmationForMessagesSent: true,
previewPrivacy: true,
torrentConfigEnabled: some(false),
torrentConfigPort: some(TORRENT_CONFIG_PORT),
Expand Down