chore: set missing message verification and confirmation for message sent enabled by default #15774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmaczko
approved these changes
Jul 24, 2024
Jenkins BuildsClick to see older builds (7)
|
richard-ramos
force-pushed
the
create-account-request-defaults
branch
from
04506be to
34a12c5
Compare
…sent enabled by default
richard-ramos
force-pushed
the
create-account-request-defaults
branch
from
34a12c5 to
5b9011b
Compare
Comment on lines
+24
to
+25
| wakuV2EnableStoreConfirmationForMessagesSent*: bool | ||
| wakuV2EnableMissingMessageVerification*: bool |
There was a problem hiding this comment.
@richard-ramos I think you missed to add these fields to toJson function below 🙁
jrainville
pushed a commit
that referenced
this pull request
Jul 30, 2024
…sent enabled by default (#15774)
jrainville
pushed a commit
that referenced
this pull request
Jul 30, 2024
…sent enabled by default (#15774)
jrainville
pushed a commit
that referenced
this pull request
Jul 30, 2024
…sent enabled by default (#15774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects new accounts. Existing accounts have already these flags set via migrations
Requires: status-im/status-go#5570