This repository was archived by the owner on Feb 23, 2023. It is now read-only.
Populate correctly the environment in BootstrapCodeGenerator #992
Comments
bclozel
changed the title
bclozel
added a commit
that referenced
this issue
Aug 26, 2021
Prior to this commit, the `ContextBootstrapContributor` would prepare an empty `Environment` and only apply some defaults to it. This lead to several sample applications failing as properties provided by the application (in `application.properties`) would not be considered. As a consequence, all `@ConditionalOnProperty` on `*.enabled` configuration keys would be discarded at build time if not enabled by default in Spring Boot. This commit loads a minimal infrastructure and prepares an `Environment` that partially loads the application configuration at build time. There are many limitations with this current approach: * this doesn't support many customizations on the `SpringApplication` * this doesn't load `Bootstrapper` so will fail with configuration trying to resolve properties using `Bootstrappers`, like Eureka. Fixes gh-992
|
Fixed with 02a7abc |
snicoll
pushed a commit
that referenced
this issue
Sep 28, 2021
Prior to this commit, the `ContextBootstrapContributor` would prepare an empty `Environment` and only apply some defaults to it. This lead to several sample applications failing as properties provided by the application (in `application.properties`) would not be considered. As a consequence, all `@ConditionalOnProperty` on `*.enabled` configuration keys would be discarded at build time if not enabled by default in Spring Boot. This commit loads a minimal infrastructure and prepares an `Environment` that partially loads the application configuration at build time. There are many limitations with this current approach: * this doesn't support many customizations on the `SpringApplication` * this doesn't load `Bootstrapper` so will fail with configuration trying to resolve properties using `Bootstrappers`, like Eureka. Fixes gh-992
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As discussed with @snicoll, the
javamailsample is broken because the environnement is not properly propagated toBootstrapCodeGeneratorRunner, for example based on theapplication.propertiesof the project. Injavamailsample case,MailSenderPropertiesConfigurationis discarded at build time because nospring.mail.hostis defined even if specified in theapplication.propertiesproject file.Like proposed in #989, we should probably use a file instead of command line arguments to pass those contextual information to
BootstrapCodeGeneratorRunner.The text was updated successfully, but these errors were encountered: