This repository was archived by the owner on Feb 23, 2023. It is now read-only.
Pass the AOT options from the plugin to BootstrapCodeGeneratorRunner #989
Comments
bclozel
added a commit
that referenced
this issue
Aug 25, 2021
Prior to this commit, the `BootstrapCodeGeneratorRunner` was implemented as a simple class with a `main` method that is passed arguments as positional parameters only. This would miss most AotOptions supported so far and could be quite difficult to maintain. This commit renames the runner to `GenerateBootstrap` and turns it into a picocli CLI command with bound options and parameters. This now supports all `remove*Support` options and some more. The Maven and Gradle build plugins have been updated accordingly to call the command with the expected arguments. This commit also removes the need to push the classpath as a command parameter and automatically extracts it using the `"java.class.path"` system property. Fixes gh-989
|
Closed with a162996 |
snicoll
pushed a commit
that referenced
this issue
Aug 25, 2021
Prior to this commit, the `BootstrapCodeGeneratorRunner` was implemented as a simple class with a `main` method that is passed arguments as positional parameters only. This would miss most AotOptions supported so far and could be quite difficult to maintain. This commit renames the runner to `GenerateBootstrap` and turns it into a picocli CLI command with bound options and parameters. This now supports all `remove*Support` options and some more. The Maven and Gradle build plugins have been updated accordingly to call the command with the expected arguments. This commit also removes the need to push the classpath as a command parameter and automatically extracts it using the `"java.class.path"` system property. Fixes gh-989
snicoll
pushed a commit
that referenced
this issue
Aug 26, 2021
Prior to this commit, the `BootstrapCodeGeneratorRunner` was implemented as a simple class with a `main` method that is passed arguments as positional parameters only. This would miss most AotOptions supported so far and could be quite difficult to maintain. This commit renames the runner to `GenerateBootstrap` and turns it into a picocli CLI command with bound options and parameters. This now supports all `remove*Support` options and some more. The Maven and Gradle build plugins have been updated accordingly to call the command with the expected arguments. This commit also removes the need to push the classpath as a command parameter and automatically extracts it using the `"java.class.path"` system property. Fixes gh-989
snicoll
pushed a commit
that referenced
this issue
Sep 28, 2021
Prior to this commit, the `BootstrapCodeGeneratorRunner` was implemented as a simple class with a `main` method that is passed arguments as positional parameters only. This would miss most AotOptions supported so far and could be quite difficult to maintain. This commit renames the runner to `GenerateBootstrap` and turns it into a picocli CLI command with bound options and parameters. This now supports all `remove*Support` options and some more. The Maven and Gradle build plugins have been updated accordingly to call the command with the expected arguments. This commit also removes the need to push the classpath as a command parameter and automatically extracts it using the `"java.class.path"` system property. Fixes gh-989
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a high priority regression we should fix, since currently AOT options like
removeYamlSupporthave no effect.I am wondering if we should use a configuration file instead of command line parameters for passing options from plugins to
BootstrapCodeGeneratorRunner.The text was updated successfully, but these errors were encountered: