-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change new identity keys to hex format #2773
fix: Change new identity keys to hex format #2773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Shahzad (I'm assuming you update the CLI docs before merge :))
Yup it's done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
+ Coverage 78.16% 78.17% +0.01%
===========================================
Files 313 313
Lines 23111 23116 +5
===========================================
+ Hits 18063 18069 +6
+ Misses 3673 3671 -2
- Partials 1375 1376 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
## Relevant issue(s) Resolves sourcenetwork#2770 ## Description - Return the priv/pub keys in hex Specify the platform(s) on which this was tested: - WSL2
Relevant issue(s)
Resolves #2770
Description
Specify the platform(s) on which this was tested: