Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defradb identity new returns keys in encoding not supported by defra calls #2770

Closed
AndrewSisley opened this issue Jun 25, 2024 · 1 comment · Fixed by #2773
Closed

defradb identity new returns keys in encoding not supported by defra calls #2770

AndrewSisley opened this issue Jun 25, 2024 · 1 comment · Fixed by #2773
Labels
area/cli Related to the CLI binary bug Something isn't working code quality Related to improving code quality feature New feature or request

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Jun 25, 2024 •
edited
Loading

The private key returned from defradb identity new is binary encoded, whereas the defra only accepts hex-encoded identity private keys.

The encoding of the value returned from defradb identity new is also not documented.
@AndrewSisley AndrewSisley added bug Something isn't working feature New feature or request code quality Related to improving code quality area/cli Related to the CLI binary labels Jun 25, 2024
@shahzadlone
Copy link
Member

Defra cli accepts hex encoded private key (which I believe is a stop gap solution until proper way to pass the key is introduced, i.e. using keyring). @nasdf can confirm perhaps.

The util command can be used to generate a pair and then the user is responsible how to and where to store it, they can store it in their key ring for example

As for the documentation of the encoding of the values, I can document it.

@shahzadlone shahzadlone mentioned this issue Jun 25, 2024
Merged
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this issue Feb 21, 2025
@shahzadlone
fix: Change new identity keys to hex format (sourcenetwork#2773)
906c042 
## Relevant issue(s)
Resolves sourcenetwork#2770 

## Description
- Return the priv/pub keys in hex

Specify the platform(s) on which this was tested:
- WSL2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli Related to the CLI binary bug Something isn't working code quality Related to improving code quality feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change new identity keys to hex format shahzadlone/defradb
2 participants
@shahzadlone @AndrewSisley