This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add Blocktree api to get transactions by slot #6966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our main downstream use case only needs to introspect confirmed blocks, with an empty result from unconfirmed ones. Currently, blocktree offers no api to return transactions in a slot.
Summary of Changes
get_confirmed_block_transactions
. Method checks whether block is confirmed (slotis_root()
) first; if so, it flattens the slot entries vec into a vec of transactions to return.It may make more sense to return an Iterator from this method in order to map each Transaction to its Result, once that data is available in blocktree. Will reassess when those apis are implemented.
getConfirmedBlock
rpc to use now blocktree api. Ifget_confirmed_block_transactions
returns an error, rpc method returns an empty result.JsonRpcRequestProcessor::get_confirmed_block()
generates mock transactions statuses, since persistent status cache is not yet implemented (CC: feat: rocksdb (persistent) transaction status cache #6958 )Toward #6867
FYI: @sunnygleason