-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: rocksdb (persistent) transaction status cache #6958
feat: rocksdb (persistent) transaction status cache #6958
Conversation
1e4add3
to
9c0e0d6
Compare
(@CriesofCarrots FYI) |
Using TransactionError is ok IMO. This is just another facet of our binary ABI that will cause a hard fork if ever changed in a way that is not backwards compatible after mainnet launch |
Yeah, my thinking was to use |
Codecov Report
@@ Coverage Diff @@
## master #6958 +/- ##
========================================
+ Coverage 74.7% 78.8% +4.1%
========================================
Files 223 223
Lines 45245 42924 -2321
========================================
+ Hits 33815 33845 +30
+ Misses 11430 9079 -2351 |
9c0e0d6
to
ae04a7c
Compare
ae04a7c
to
d1b6153
Compare
@CriesofCarrots ok, I think this is worth a look -- looking forward to your feedback! |
🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, one suggestion, then let's
25807c5
to
5a5d181
Compare
Problem
getConfirmedBlock
RPC method #6867)Summary of Changes
Open Issues
Fixes # N/A (potentially multiple)