This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ci: treewide: deny used_underscore_binding #31319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
force-pushed
the
clippy-used-underscore-binding
branch
from
04d175d to
c376497
Compare
ryoqun
changed the title
3 tasks
ryoqun
changed the title
ryoqun
changed the title
ryoqun
changed the title
Codecov Report
@@ Coverage Diff @@
## master #31319 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 734 734
Lines 207153 207147 -6
=========================================
- Hits 168955 168939 -16
- Misses 38198 38208 +10 |
ryoqun
changed the title
ryoqun
commented
Apr 24, 2023
ryoqun
force-pushed
the
clippy-used-underscore-binding
branch
from
0e8fb1c to
4d480a2
Compare
ryoqun
commented
Apr 24, 2023
ryoqun
commented
Apr 24, 2023
This was referenced Apr 24, 2023
ryoqun
commented
Apr 24, 2023
apfitzge
reviewed
Apr 24, 2023
| @@ -78,6 +78,7 @@ nightly_clippy_allows=() | |||
| --deny=warnings \ | |||
| --deny=clippy::default_trait_access \ | |||
| --deny=clippy::integer_arithmetic \ | |||
| --deny=clippy::used_underscore_binding \ | |||
There was a problem hiding this comment.
Just adding a comment here with ref to clippy-lint description: https://rust-lang.github.io/rust-clippy/master/#used_underscore_binding
apfitzge
previously approved these changes
Apr 24, 2023
ryoqun
commented
Apr 25, 2023
ryoqun
force-pushed
the
clippy-used-underscore-binding
branch
from
6347179 to
a867a1d
Compare
|
@yihau could you approve this quickly? I've finished to collect all the stamps for this tree-wide small changes. |
ilya-bobyr
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using
_-prefixed variables are odd: #31239 (comment)Summary of Changes
Remove and deny them in the future.
Fixes #