This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Actively manage dead slots in AncestorHashesService #18912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
FixRepairService
branch
from
04b187c to
e6ca84a
Compare
carllin
force-pushed
the
FixRepairService
branch
from
e6ca84a to
6070330
Compare
Codecov Report
@@ Coverage Diff @@
## master #18912 +/- ##
=========================================
+ Coverage 82.8% 82.9% +0.1%
=========================================
Files 444 444
Lines 126716 127275 +559
=========================================
+ Hits 104941 105607 +666
+ Misses 21775 21668 -107 |
carllin
force-pushed
the
FixRepairService
branch
2 times, most recently
from
9cc3de5 to
16d6f16
Compare
carllin
force-pushed
the
FixRepairService
branch
from
16d6f16 to
323bbe7
Compare
AshwinSekar
reviewed
Jul 29, 2021
carllin
force-pushed
the
FixRepairService
branch
from
4ca785d to
4d71642
Compare
mergify
bot
dismissed
AshwinSekar’s stale review
Pull request has been modified.
carllin
force-pushed
the
FixRepairService
branch
from
4d71642 to
b503924
Compare
AshwinSekar
approved these changes
Aug 2, 2021
ryoqun
reviewed
Apr 24, 2023
| repairable_dead_slot_pool: HashSet<Slot>, | ||
| request_throttle: Vec<u64>, | ||
| repair_stats: AncestorRepairRequestsStats, | ||
| _duplicate_slots_reset_receiver: DuplicateSlotsResetReceiver, |
There was a problem hiding this comment.
here xref: #31319 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AncestorHashesService doesn't currently make ancestor requests
Summary of Changes
dead_slot_pooldead_slot_poolto an eligible repair pool,repairable_dead_slot_poolrepairable_dead_slot_poolslots are removed once anAncestorHashesrequest is made for that slot. The status of the request is tracked inancestor_hashes_request_statusesancestor_hashes_request_statuses.repairable_dead_slot_pool, and will be retried later.Fixes #
#18783