-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default ViewState #2802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to check it on Android also. |
tomekzaw
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
3 tasks
When will this be published? 😄 |
3 tasks
Any idea when this will be released? :) |
aeddi
pushed a commit
to aeddi/react-native-reanimated
that referenced
this pull request
Mar 22, 2022
## Description The problem occurs since software-mansion#2651 Why? Layout animations are disabled by default until someone call layout animation. Then layout animation is enabled. The problem is when someone uses layout animation in components that don't appear in the first render. It breaks the previous assumption of layout animation - "every component is sent to `onViewCreate` function". In effect, we tried to remove the view that wasn't registered in `_viewForTag` register. There was also another problem because uses this: ```c++ ViewState state = [_states[tag] intValue]; ``` without checking if `_states[tag]` is `nil`. Then `nil` was converted to `0` and then to the first value from `ViewState` (`Appearing`), but this is wrong because the default state should be `Inactive` because not every component has animation. I added similar changes for Android also. ## Reproduction ```js import React from 'react'; import { useEffect, useState } from 'react'; import { ActivityIndicator, StyleSheet, Text, View, findNodeHandle } from 'react-native'; import Animated, { FadeOutDown } from 'react-native-reanimated'; export default function App() { const [isLoading, setIsLoading] = useState<boolean>(true); useEffect(() => { const timeout = setTimeout(() => setIsLoading(false), 500); return () => { clearTimeout(timeout); }; }, []); return ( <View style={styles.container}> { isLoading ? <ActivityIndicator size='large' color='red' /> : <Animated.View exiting={FadeOutDown} style={styles.scrollContainer}> {[...Array(10).keys()].map((value) => ( <View style={styles.row} key={value}> <Text>row n°{value}</Text> </View> ))} </Animated.View> } </View> ); } const styles = StyleSheet.create({ container: { flex: 1, backgroundColor: '#fff', alignItems: 'center', justifyContent: 'center', }, scrollContainer: { flex: 1, width: '100%', }, row: { flexDirection: 'row', backgroundColor: 'transparent', height: 50, }, }); ``` Fixes software-mansion#2758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem occurs since #2651
Why?
Layout animations are disabled by default until someone call layout animation. Then layout animation is enabled. The problem is when someone uses layout animation in components that don't appear in the first render. It breaks the previous assumption of layout animation - "every component is sent to
onViewCreate
function". In effect, we tried to remove the view that wasn't registered in_viewForTag
register.There was also another problem because uses this:
without checking if
_states[tag]
isnil
. Thennil
was converted to0
and then to the first value fromViewState
(Appearing
), but this is wrong because the default state should beInactive
because not every component has animation.I added similar changes for Android also.
Reproduction
Fixes #2758