Disable by default layout animation #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
commented
Nov 22, 2021
src/reanimated2/core.ts
Outdated
| if (!filteredOptions) { | ||
| return; | ||
| } | ||
| NativeReanimatedModule.setEnableFeatures(filteredOptions); |
There was a problem hiding this comment.
You need to add implementation for web
piaskowyk
commented
Nov 23, 2021
kmagiera
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
This looks ok, however, I think it'd be easier to add just one flag specifically for turning on layout animation as opposed to designing more generic solution to it.
If instead of setEnableFeatures we'd just have enableLayoutAnimations function we could:
- not really care about web implementation too much. Layout Animations does not work on web so we could just no-op there
- we now call
setEnableFeatureson every component render. If it was just setting a single boolean variable we'd avoid additional complexity of merging and filtering dicts
piaskowyk
added a commit
that referenced
this pull request
Jan 4, 2022
## Description The problem occurs since #2651 Why? Layout animations are disabled by default until someone call layout animation. Then layout animation is enabled. The problem is when someone uses layout animation in components that don't appear in the first render. It breaks the previous assumption of layout animation - "every component is sent to `onViewCreate` function". In effect, we tried to remove the view that wasn't registered in `_viewForTag` register. There was also another problem because uses this: ```c++ ViewState state = [_states[tag] intValue]; ``` without checking if `_states[tag]` is `nil`. Then `nil` was converted to `0` and then to the first value from `ViewState` (`Appearing`), but this is wrong because the default state should be `Inactive` because not every component has animation. I added similar changes for Android also. ## Reproduction ```js import React from 'react'; import { useEffect, useState } from 'react'; import { ActivityIndicator, StyleSheet, Text, View, findNodeHandle } from 'react-native'; import Animated, { FadeOutDown } from 'react-native-reanimated'; export default function App() { const [isLoading, setIsLoading] = useState<boolean>(true); useEffect(() => { const timeout = setTimeout(() => setIsLoading(false), 500); return () => { clearTimeout(timeout); }; }, []); return ( <View style={styles.container}> { isLoading ? <ActivityIndicator size='large' color='red' /> : <Animated.View exiting={FadeOutDown} style={styles.scrollContainer}> {[...Array(10).keys()].map((value) => ( <View style={styles.row} key={value}> <Text>row n°{value}</Text> </View> ))} </Animated.View> } </View> ); } const styles = StyleSheet.create({ container: { flex: 1, backgroundColor: '#fff', alignItems: 'center', justifyContent: 'center', }, scrollContainer: { flex: 1, width: '100%', }, row: { flexDirection: 'row', backgroundColor: 'transparent', height: 50, }, }); ``` Fixes #2758
aeddi
pushed a commit
to aeddi/react-native-reanimated
that referenced
this pull request
Mar 22, 2022
## Description The problem occurs since software-mansion#2651 Why? Layout animations are disabled by default until someone call layout animation. Then layout animation is enabled. The problem is when someone uses layout animation in components that don't appear in the first render. It breaks the previous assumption of layout animation - "every component is sent to `onViewCreate` function". In effect, we tried to remove the view that wasn't registered in `_viewForTag` register. There was also another problem because uses this: ```c++ ViewState state = [_states[tag] intValue]; ``` without checking if `_states[tag]` is `nil`. Then `nil` was converted to `0` and then to the first value from `ViewState` (`Appearing`), but this is wrong because the default state should be `Inactive` because not every component has animation. I added similar changes for Android also. ## Reproduction ```js import React from 'react'; import { useEffect, useState } from 'react'; import { ActivityIndicator, StyleSheet, Text, View, findNodeHandle } from 'react-native'; import Animated, { FadeOutDown } from 'react-native-reanimated'; export default function App() { const [isLoading, setIsLoading] = useState<boolean>(true); useEffect(() => { const timeout = setTimeout(() => setIsLoading(false), 500); return () => { clearTimeout(timeout); }; }, []); return ( <View style={styles.container}> { isLoading ? <ActivityIndicator size='large' color='red' /> : <Animated.View exiting={FadeOutDown} style={styles.scrollContainer}> {[...Array(10).keys()].map((value) => ( <View style={styles.row} key={value}> <Text>row n°{value}</Text> </View> ))} </Animated.View> } </View> ); } const styles = StyleSheet.create({ container: { flex: 1, backgroundColor: '#fff', alignItems: 'center', justifyContent: 'center', }, scrollContainer: { flex: 1, width: '100%', }, row: { flexDirection: 'row', backgroundColor: 'transparent', height: 50, }, }); ``` Fixes software-mansion#2758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the possibility to disable layout animations. By default layout animations are disabled, but you don't need to turn it on manually, because these will be enabled if you will use the
entering/exiting/layoutprop in an animated component. You also have the possibility to disable/enable it manually.Example