Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endpoints)!: integrate endpoints 2.0 #433

Merged
merged 10 commits into from
Oct 27, 2022
Merged

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 17, 2022

Issue #

awslabs/aws-sdk-swift#624

Description of changes

Counterpart: awslabs/aws-sdk-swift#607

  • Introduces endpoint string config at SDK config level
  • Add supports for headers and attribute to Endpoint to allow returning headers and metadata (auth schemes) as part of endpoint resolution.
  • Codegen update to start creating service specific configuration protocol.

Ex.
Before

protocol ExampleServiceProtocol  {
}

After

protocol ExampleServiceProtocol  {
}

protocol ExampleServiceConfigurationProtocol {
}

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ganeshnj ganeshnj changed the title endpoints refactor feat: endpoints refactor Aug 17, 2022
@ganeshnj ganeshnj force-pushed the jangirg/feat/endpoints-2 branch from 05354c2 to 0ae2f55 Compare August 24, 2022 22:16
@ganeshnj ganeshnj changed the title feat: endpoints refactor refactor: endpoints Aug 24, 2022
@ganeshnj ganeshnj force-pushed the jangirg/feat/endpoints-2 branch 3 times, most recently from e98b5e0 to fb2d1f5 Compare August 30, 2022 00:49
@ganeshnj ganeshnj changed the title refactor: endpoints feat(endpoints)!: integrate endpoints 2.0 Aug 30, 2022
@ganeshnj ganeshnj marked this pull request as ready for review August 30, 2022 01:01
@jbelkins jbelkins self-requested a review September 2, 2022 16:40
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for awareness, not so much for correctness.

@ganeshnj ganeshnj force-pushed the jangirg/feat/endpoints-2 branch from ac4b728 to f8bd83c Compare October 3, 2022 16:11
@ganeshnj ganeshnj mentioned this pull request Oct 5, 2022
6 tasks
@ganeshnj ganeshnj merged commit 092b9ed into main Oct 27, 2022
@ganeshnj ganeshnj deleted the jangirg/feat/endpoints-2 branch October 27, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants