Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit conformance for Equatable and Hashable on Header, Comparable on URLQueryItem #451

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

ganeshnj
Copy link
Contributor

Issue #

Description of changes

Change required for awslabs/aws-sdk-swift#651

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ganeshnj ganeshnj marked this pull request as ready for review October 19, 2022 23:59
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, I just think some documentation comments are warranted

@ganeshnj ganeshnj requested a review from jbelkins October 20, 2022 16:36
@ganeshnj ganeshnj merged commit c03aabb into jangirg/feat/endpoints-2 Oct 20, 2022
@ganeshnj ganeshnj deleted the jangirg/fix/endpoint-2-params branch October 20, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants