both sidebars get full height on embed #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrm
requested review from
interim17,
frasercl and
blairlyons
and removed request for
a team and
interim17
Coverage report
Test suite run success104 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 59dca1a |
blairlyons
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
xsmall
Problem
there was a gap of whitespace on the bottom of the plots in the embed view
Solution
made sure both sidebars got the embed class
Type of change
Please delete options that are not relevant.
Screenshots (optional):
what it looked like before:
