Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/default octopus #530

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix/default octopus #530

merged 3 commits into from
Jun 11, 2024

Conversation

ascibisz
Copy link
Contributor

@ascibisz ascibisz commented Jun 10, 2024

Time estimate or Size

xsmall

Problem

Last piece of this ticket

Solution

Update the viewer version, and remove params in net connection settings that don't exist any longer now that we are always pointing to Octopus.

This pulls in the viewer changes from this PR

@ascibisz ascibisz force-pushed the fix/default-octopus branch from bedfb06 to f24946d Compare June 10, 2024 23:12
Copy link

github-actions bot commented Jun 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 66.32% 644/971
🟡 Branches 65.73% 94/143
🔴 Functions 35.1% 86/245
🟡 Lines 64.72% 576/890

Test suite run success

104 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from f20c42f

@ascibisz ascibisz marked this pull request as ready for review June 10, 2024 23:15
@ascibisz ascibisz requested a review from a team as a code owner June 10, 2024 23:15
@ascibisz ascibisz requested review from meganrm and interim17 and removed request for a team June 10, 2024 23:15
@ascibisz ascibisz merged commit 4e94bb5 into main Jun 11, 2024
6 checks passed
@ascibisz ascibisz deleted the fix/default-octopus branch June 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants