Fix/icomoon #476

interim17 · 2024-03-08T18:02:14Z

Time to review:

Small < 10 minutes

Problem:

Icomoon font glyphs had not been updated in a long time and they were written into the code base in hard to understand ways. New icons had been added in other ways, with conflicting design approaches.

Solution:

Create new set of glyphs, define each glyph as a css variable, apply those variables via global style selectors.
I added some explanatory comments about how to use this styling pattern because I found it confusing at first, which led to me adding icons in suboptimal ways. Updating the font was easy! I just didn't realize...

Part of preliminary changes/maintenance to fixing all styles on the playback and camera control buttons.

Other changes:

Moved global style imports to src/style.css why were they in the SideBar component?
Removed some unused style rules, cleaned up an import or two

To review:

Confirm all the icons match current guidance in the figma guide, the relevant icons are all in playback controls, camera controls, and the highlighting stars in the side panel. (Rotate and home/reset were wrong, orthographic/perspective were correct icon but way wrong size)
Confirm that the styling/spacing is not egregiously worse.
Note: The buttons and the icon positioning inside them do not match the style guide on staging, production, or this branch... I have a change-set lined up for this, out of scope for this PR to fix it all. If we can get these icons organized and available for styling we can fix this the right way.

interim17 · 2024-03-08T18:02:34Z

src/components/AgentTree/style.css

-.star-icon::after {
-    content: "\e902";
-    color: var(--dark-theme-sidebar-text);
-}
-


This rule was unused as far as I could tell.

interim17 · 2024-03-08T18:03:18Z

src/style.css

+
+@import "./styles/colors.css";
+@import "./styles/constants.css";
+@import "./styles/icons.css";
+


These imports were in a seemingly random component file, makes more sense here.

interim17 · 2024-03-08T18:06:00Z

src/style.css

+ /* Current in-use icons */
+.star-empty-icon::after {
+    content: var(--star-empty);
+    color: var(--warm-gray)


Existing rules defining global style rules were all unused with a comment that they were just for storage. Icons in use had their content provided via code string in stylesheets (i.e. content: "\e909") which gave no indication what the content was. This pattern defined here makes a lot of sense! I think we should use it all the time, not just for storing unused icons.

interim17 · 2024-03-08T18:06:48Z

src/components/CameraControls/index.tsx

@@ -4,7 +4,7 @@ import classNames from "classnames";
 import { useHotkeys, useIsHotkeyPressed } from "react-hotkeys-hook";

 import { TOOLTIP_COLOR } from "../../constants/index";
-import Icons from "../Icons";
+import { ZoomIn, ZoomOut } from "../Icons";


This is how we do it in most parts of the repo, changing to match.

github-actions · 2024-03-08T18:07:28Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	73.27%	603/823
🟡	Branches	68.38%	80/117
🔴	Functions	40.31%	79/196
🟡	Lines	71.73%	538/750

Test suite run success

99 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 7ca5f10

interim17 · 2024-03-08T18:07:33Z

src/components/CameraControls/index.tsx

@@ -189,7 +189,7 @@ const CameraControls = ({
                                className={classNames([
                                    "icon-moon",
                                    "anticon",
-                                    styles.rotate,
+                                    "rotate-icon",


These class names now point to a global style rule, which references a css variable, rather than pointing at a component style sheet that directly references icomoon glyph code.

interim17 · 2024-03-08T18:08:46Z

src/components/Icons/index.tsx

@@ -70,6 +60,4 @@ export default {
    Link,
    Download,
    LoopOutlined,
-    OrthographicCamera,
-    PerspectiveCamera,
 };


Removed icons are now in icomoon font.

ShrimpCryptid · 2024-03-08T21:51:54Z

src/components/CameraControls/index.tsx

                    <Button
                        className={styles.btn}
-                        icon={Icons.ZoomIn}
+                        icon={ZoomIn}
                        onClick={zoomIn}


Nit: Should these buttons have an aria-label or other readable text label, or is that included with the icon itself?

Great point, fits better in the next set of changes, noted!

ShrimpCryptid · 2024-03-08T21:53:29Z

src/styles/icons.css

Love this change!

ShrimpCryptid

Looks good, left a comment about accessibility for the various buttons and icons.

meganrm

This looks good

commit e20842b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 13:32:28 2024 -0700 Fix/icomoon (#476) * new icon glyph set * apply icomoon icons with css vars and global styles * remove unused icons * remove icon declarations now in icomoon font * use var for star icon colors * new icomoon font set commit 1980c09 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Mar 12 12:05:34 2024 -0700 Feature/embed (#474) * fix the html loader result * add type * embed path * make sure the loading overlay shows * style title * remove extra color * remove log * remove unused code commit 50a8c6f Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 10:43:06 2024 -0700 fix: organize colors, modal buttons (#473) * organize and prune color variables and apply light theme at custom modal level * use var for disabled input text color * prevent flicker on select file button * remove classnames import from file upload modal * restore necessry whitespace in version modal text * position close x correctly in modal header * fix typo in focus selector * remove unneeded ant animation prop commit a317426 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 11 11:51:56 2024 -0700 reverse home page card order (#472) commit bb038e1 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Mar 8 10:56:44 2024 -0800 fix the html loader result (#475) * fix the html loader result * add type

commit 41f8139 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 18 19:45:23 2024 -0700 feature/viewport button component (#478) * add viewport button component and organize dark theme colors * use antd tooltip placement prop type commit 4796413 Author: ascibisz <alli.scibisz@alleninstitute.org> Date: Mon Mar 18 11:21:32 2024 -0700 0.11.0 commit e20842b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 13:32:28 2024 -0700 Fix/icomoon (#476) * new icon glyph set * apply icomoon icons with css vars and global styles * remove unused icons * remove icon declarations now in icomoon font * use var for star icon colors * new icomoon font set commit 1980c09 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Mar 12 12:05:34 2024 -0700 Feature/embed (#474) * fix the html loader result * add type * embed path * make sure the loading overlay shows * style title * remove extra color * remove log * remove unused code commit 50a8c6f Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 10:43:06 2024 -0700 fix: organize colors, modal buttons (#473) * organize and prune color variables and apply light theme at custom modal level * use var for disabled input text color * prevent flicker on select file button * remove classnames import from file upload modal * restore necessry whitespace in version modal text * position close x correctly in modal header * fix typo in focus selector * remove unneeded ant animation prop commit a317426 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 11 11:51:56 2024 -0700 reverse home page card order (#472) commit bb038e1 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Mar 8 10:56:44 2024 -0800 fix the html loader result (#475) * fix the html loader result * add type

commit 092f511 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Mar 22 16:20:24 2024 -0700 fix/hide tooltips after click (#477) * mange toolltip title and open with local state * use optional chaining for possibly null functions commit 41f8139 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 18 19:45:23 2024 -0700 feature/viewport button component (#478) * add viewport button component and organize dark theme colors * use antd tooltip placement prop type commit 4796413 Author: ascibisz <alli.scibisz@alleninstitute.org> Date: Mon Mar 18 11:21:32 2024 -0700 0.11.0 commit e20842b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 13:32:28 2024 -0700 Fix/icomoon (#476) * new icon glyph set * apply icomoon icons with css vars and global styles * remove unused icons * remove icon declarations now in icomoon font * use var for star icon colors * new icomoon font set commit 1980c09 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Mar 12 12:05:34 2024 -0700 Feature/embed (#474) * fix the html loader result * add type * embed path * make sure the loading overlay shows * style title * remove extra color * remove log * remove unused code commit 50a8c6f Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 10:43:06 2024 -0700 fix: organize colors, modal buttons (#473) * organize and prune color variables and apply light theme at custom modal level * use var for disabled input text color * prevent flicker on select file button * remove classnames import from file upload modal * restore necessry whitespace in version modal text * position close x correctly in modal header * fix typo in focus selector * remove unneeded ant animation prop commit a317426 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 11 11:51:56 2024 -0700 reverse home page card order (#472) commit bb038e1 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Mar 8 10:56:44 2024 -0800 fix the html loader result (#475) * fix the html loader result * add type

commit f622cae Author: Joe Heffernan <interim17@gmail.com> Date: Tue Apr 2 09:12:34 2024 -0700 Fix/update custom modal (#482) * use custom modal wrapper for more layout and styling * remove duplicate and unused colors * remove more duplicated colors * remove comments * remove unused import from starcheckbox * simplify time input css selector * fix spelling errors in "shareable" * omit unused ModalProps from CustomModalProps * add comment to share modal input styles commit 0af4198 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Apr 1 09:48:40 2024 -0700 Fix/header buttons (#484) * custom nav button component for header buttons * remove tooltip button stylesheet * make header a functional component and implement nav buttons * remove animation on home button * remove unneeded style sheets and class names from action button components * use interface for tooltip text * remove unused import * delete unused stylesheet * move tooltip placement type to constants * default nav buttons to action styling and trim selectors * provide default disabled tooltip text and simplify conditional checks commit f527adb Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Mar 28 11:16:17 2024 -0700 Bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#481) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 092f511 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Mar 22 16:20:24 2024 -0700 fix/hide tooltips after click (#477) * mange toolltip title and open with local state * use optional chaining for possibly null functions commit 41f8139 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 18 19:45:23 2024 -0700 feature/viewport button component (#478) * add viewport button component and organize dark theme colors * use antd tooltip placement prop type commit 4796413 Author: ascibisz <alli.scibisz@alleninstitute.org> Date: Mon Mar 18 11:21:32 2024 -0700 0.11.0 commit e20842b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 13:32:28 2024 -0700 Fix/icomoon (#476) * new icon glyph set * apply icomoon icons with css vars and global styles * remove unused icons * remove icon declarations now in icomoon font * use var for star icon colors * new icomoon font set commit 1980c09 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Mar 12 12:05:34 2024 -0700 Feature/embed (#474) * fix the html loader result * add type * embed path * make sure the loading overlay shows * style title * remove extra color * remove log * remove unused code commit 50a8c6f Author: Joe Heffernan <interim17@gmail.com> Date: Tue Mar 12 10:43:06 2024 -0700 fix: organize colors, modal buttons (#473) * organize and prune color variables and apply light theme at custom modal level * use var for disabled input text color * prevent flicker on select file button * remove classnames import from file upload modal * restore necessry whitespace in version modal text * position close x correctly in modal header * fix typo in focus selector * remove unneeded ant animation prop commit a317426 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Mar 11 11:51:56 2024 -0700 reverse home page card order (#472) commit bb038e1 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Mar 8 10:56:44 2024 -0800 fix the html loader result (#475) * fix the html loader result * add type commit 90bb378 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Mar 1 13:13:40 2024 -0800 Feature/og tags (#463) * add meta image asset * add open graph meta tags to html * use html-loader commit 6f0d974 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Mar 1 12:23:34 2024 -0800 Fix/nav tooltips (#469) * remove right justify * make sure all modals are getting consistent button styling * fix hover issues * keep close x from disappearing * change color vars to semantic ones * make share target bigger * use semantic var name * fix typo due to copy paste * change tooltip delay name * fix tooltip issues * remove unneeded style * revert change * DRYer * close tooltip if sharing * only update state if open commit 9f2604c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Mar 1 11:53:15 2024 -0800 Bump es5-ext from 0.10.62 to 0.10.64 (#471) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. - [Release notes](https://github.com/medikoo/es5-ext/releases) - [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md) - [Commits](medikoo/es5-ext@v0.10.62...v0.10.64) --- updated-dependencies: - dependency-name: es5-ext dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit bfca6a4 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Feb 28 09:16:15 2024 -0800 set slider range props to false and remove array from handler argument types (#470) commit 036033c Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Thu Feb 22 13:52:14 2024 -0800 Fix/url modal (#466) * remove right justify * make sure all modals are getting consistent button styling * fix hover issues * keep close x from disappearing * change color vars to semantic ones * make share target bigger * use semantic var name * fix typo due to copy paste * revert change commit bd82044 Author: Blair Lyons <blair208@gmail.com> Date: Thu Feb 22 12:21:10 2024 -0800 Update CODEOWNERS commit 80017da Author: Blair Lyons <blair208@gmail.com> Date: Thu Feb 22 12:00:10 2024 -0800 add time estimate or size to PR template commit f352762 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Feb 14 17:42:55 2024 -0800 Fix/bump react (#461) * bump react, react-waypoint, react dom, @types/react * declare children in sider and upload props for react 18 compatibility * bump @types/react-dom * use createRoot API to render App * commit lock file * bump to viewer 3.7.0 with react 18 * use non-null assertion on container in createRoot call commit 39a6f7b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 29 19:28:31 2024 -0800 Bump follow-redirects from 1.15.2 to 1.15.4 (#460) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6b26307 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 29 19:28:19 2024 -0800 Bump plotly.js from 2.20.0 to 2.25.2 (#457) Bumps [plotly.js](https://github.com/plotly/plotly.js) from 2.20.0 to 2.25.2. - [Release notes](https://github.com/plotly/plotly.js/releases) - [Changelog](https://github.com/plotly/plotly.js/blob/master/CHANGELOG.md) - [Commits](plotly/plotly.js@v2.20.0...v2.25.2) --- updated-dependencies: - dependency-name: plotly.js dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 38dda7c Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jan 4 10:27:17 2024 -0800 open aics homepage in new tab (#454) commit 106935b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Dec 19 11:51:35 2023 -0800 Feature/color picker (#432) * initial components and styling * shrink checkbox to expose swatch * shrink chexbox to make swatch clickable * pass data into color swatch * remove unused styling * handleColorChange in picker * pass props and helders to color picker modal * add colorPicker to color swatch * types actions constants selectors for colorChanges * selector in viewer panel * preserve initial color in swatch * style parent swatch when children dont match * recent colors into redux * change modal to popover * update import * clean up stylesheets * tidy css and imports * bump viewer version * remove extra ? * update viewer * viewerpanel selector test update * update dependecies * add tests for getColorChanges * fix type imports in selectors * web app version * remove comment * consolidate colorpicker and popover * organize props and style rules * pointer on color swatch * formatting * color picker tooltip color to constant * swap replace for slice * debounce color selection * implement orthographic camera * initial styling of camera controls * ortho/perspective icons * define viewer button color variables * focus:hover state on home button * playback control styling * fix button exceeding border * orth/persp icons swapped * remove redundant ternary * rename set camera * audit fix (#437) * change check for if a file is shareable (#439) * change check for if a file is shareable * use constant for trajFileName * use selector instead of type guard * add unit test * remove accidental auto import * Update ux_issue.md (#433) * menu item and modal * removing logs * remove unneeded jsx fragment wrappers * remove commented code * styling update * remove comments * typo * prevent bg color change after click * Update src/components/HelpMenu/index.tsx Co-authored-by: Megan Riel-Mehan <meganrm@gmail.com> * fix menus offsets (#440) * fix menus offsets * move version info * update viewer to 3.6.3 * update viewer and fix types (#445) * 0.10.0 * remove redunant line * implement orthographic camera * initial styling of camera controls * define viewer button color variables * focus:hover state on home button * playback control styling * orth/persp icons swapped * remove redundant ternary * install new viewer version * rename set camera * menu item and modal * removing logs * remove unneeded jsx fragment wrappers * remove commented code * styling update * remove comments * typo * Update src/components/HelpMenu/index.tsx Co-authored-by: Megan Riel-Mehan <meganrm@gmail.com> * fix menus offsets (#440) * fix menus offsets * move version info * update viewer to 3.6.3 * update viewer and fix types (#445) * pass down actions from model panel to picker * add hover state rules * pass in debouncedColor * [to undo] - local install * remove colorChangesMap * prevent color assignment on first opening picker * fix typing and save all color changes * make color change an object * install * store colors for correct rendering * add a done call * change interface * install viewer * update viewer * remove old style sheet * clean up styles and change order on parents * style children selection row * style labels * style sub menu better * clean up styles * revert change * make sure colors are consistently cased * fix imports * wip - not have popover move up * remove color swatch component and get color picker aligned with swatch * flx classnames * fix typo * fix checkall button * fix classname * make render functions for colorpicker * keep swatch constant until color is set, change label to "previous" * adjusting labels * Update src/components/CheckBoxTree/style.css Co-authored-by: Peyton Lee <peyton.lee@alleninstitute.org> * rename colors * sync children remove log * Fix/viewer imports (#453) * fix imports to be from the top level * update viewer * Update src/components/SharedCheckbox/style.css Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com> * remove return * clean up styling * change names of checkboxtree components --------- Co-authored-by: Megan Riel-Mehan <meganrm@gmail.com> Co-authored-by: Lyndsay <93954795+lynwilhelm@users.noreply.github.com> Co-authored-by: Blair Lyons <blair208@gmail.com> Co-authored-by: Peyton Lee <peyton.lee@alleninstitute.org> Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com> commit 7bfdc1f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Dec 8 14:21:10 2023 -0800 Bump @adobe/css-tools from 4.3.1 to 4.3.2 (#449) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 37a5fee Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Dec 8 14:18:05 2023 -0800 Update test-coverage.yml commit f926754 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Dec 8 14:15:46 2023 -0800 Update test-coverage.yml commit 16de0a0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Dec 8 14:03:32 2023 -0800 Bump axios from 0.21.4 to 1.6.0 (#447) Bumps [axios](https://github.com/axios/axios) from 0.21.4 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.21.4...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: meganrm <meganrm@gmail.com> commit 8fad286 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Dec 8 13:53:25 2023 -0800 check if it's a dependabot PR (#450) commit 4d149c8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 4 13:35:30 2023 -0800 Bump @babel/traverse from 7.20.5 to 7.23.2 (#442) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit b432dff Author: Joe Heffernan <interim17@gmail.com> Date: Wed Nov 29 13:34:18 2023 -0800 Fix/share download styling (#448) * add color * remove pipe and fix button order * fix download button styling * fix share button styling * remove whitespace * change hover state selector to sync with tooltip * turn functions to boolean constants * streamline tooltip constants * move btn styles to appheader commit c6eaea3 Author: Blair Lyons <blair208@gmail.com> Date: Mon Oct 23 11:06:47 2023 -0700 0.10.0 commit f13dcb0 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Fri Oct 20 12:46:48 2023 -0700 update viewer and fix types (#445) commit 4baff29 Author: Blair Lyons <blair208@gmail.com> Date: Thu Oct 19 14:49:46 2023 -0700 update viewer to 3.6.3 commit ca5ac24 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Mon Oct 16 10:41:45 2023 -0700 fix menus offsets (#440) * fix menus offsets * move version info commit 244e726 Merge: 60326cf 836510a Author: Joe Heffernan <interim17@gmail.com> Date: Wed Oct 11 13:32:07 2023 -0700 Merge pull request #423 from simularium/feature/version-info Feature/version info commit 836510a Author: Joe Heffernan <interim17@gmail.com> Date: Wed Oct 11 11:47:54 2023 -0700 Update src/components/HelpMenu/index.tsx Co-authored-by: Megan Riel-Mehan <meganrm@gmail.com> commit caac57b Author: Joe Heffernan <interim17@gmail.com> Date: Tue Oct 10 12:51:42 2023 -0700 prevent bg color change after click commit 23be0d4 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Oct 9 15:27:12 2023 -0700 typo commit 141b037 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Oct 9 14:34:44 2023 -0700 remove comments commit 8dcccc1 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Oct 9 14:34:28 2023 -0700 styling update commit 4c215c7 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Oct 9 14:14:01 2023 -0700 remove commented code commit 72c2e8d Author: Joe Heffernan <interim17@gmail.com> Date: Mon Oct 9 14:10:35 2023 -0700 remove unneeded jsx fragment wrappers commit dcff5c8 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 11:27:55 2023 -0700 removing logs commit 3e9d578 Author: Joe Heffernan <interim17@gmail.com> Date: Tue May 23 10:56:42 2023 -0700 menu item and modal commit 60326cf Author: Lyndsay <93954795+lynwilhelm@users.noreply.github.com> Date: Mon Oct 9 12:57:20 2023 -0700 Update ux_issue.md (#433) commit 72f1a23 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Mon Oct 9 12:57:08 2023 -0700 change check for if a file is shareable (#439) * change check for if a file is shareable * use constant for trajFileName * use selector instead of type guard * add unit test * remove accidental auto import commit 67f2f58 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Thu Oct 5 13:28:50 2023 -0700 audit fix (#437) commit af14d01 Merge: 1314eed a78dee4 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Sep 8 14:50:10 2023 -0700 Merge pull request #430 from simularium/feature/orthographic-ui Feature/orthographic UI commit a78dee4 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Sep 8 09:21:09 2023 -0700 rename set camera commit 49598cc Author: Joe Heffernan <interim17@gmail.com> Date: Mon Aug 28 19:00:29 2023 -0700 install new viewer version commit d5b8440 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 17 16:16:45 2023 -0700 remove redundant ternary commit aa0fc41 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 17 16:15:09 2023 -0700 orth/persp icons swapped commit 1b92d70 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Aug 16 13:50:33 2023 -0700 fix button exceeding border commit 4969ca9 Merge: 29137a3 1314eed Author: Joe Heffernan <interim17@gmail.com> Date: Wed Aug 16 13:28:05 2023 -0700 Merge branch 'main' into feature/orthographic-ui merging main commit 29137a3 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Aug 14 13:01:55 2023 -0700 playback control styling commit 8756d05 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Aug 14 13:00:59 2023 -0700 focus:hover state on home button commit 4506ce9 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 10 12:26:56 2023 -0700 define viewer button color variables commit f3cc830 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 10 12:25:50 2023 -0700 ortho/perspective icons commit b23d847 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 10 12:25:26 2023 -0700 initial styling of camera controls commit fab1840 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Aug 10 12:23:15 2023 -0700 implement orthographic camera commit 1314eed Merge: 2c949aa b9c37b2 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jul 20 16:37:06 2023 -0700 Merge pull request #424 from simularium/feature/share-time-url Feature/share time url commit b9c37b2 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jul 20 13:19:13 2023 -0700 tooltip handler edit, fix alignment on time input commit 2c949aa Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Mon Jul 17 14:56:28 2023 -0700 Update CODEOWNERS commit 81bce36 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Jul 11 16:17:20 2023 -0700 change gh-deploy to be a dev build (#426) commit 01468c3 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Jul 11 16:17:03 2023 -0700 Update CONTRIBUTING.md (#425) commit 5ad5660 Merge: 0b79159 5dda5da Author: meganrm <meganrm@gmail.com> Date: Tue Jun 27 17:41:25 2023 -0700 Merge branch 'feature/share-time-url' of https://github.com/simularium/simularium-website into feature/share-time-url commit 0b79159 Author: meganrm <meganrm@gmail.com> Date: Tue Jun 27 17:41:18 2023 -0700 reduce annotations commit 5dda5da Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 15:13:51 2023 -0700 update return type receiveTimeChange commit 5113dfe Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 13:57:59 2023 -0700 update test commit 1e226e8 Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 13:48:29 2023 -0700 test for editUrlParams and clean up commit b93f789 Author: meganrm <meganrm@gmail.com> Date: Tue Jun 27 12:19:00 2023 -0700 changed names of functions commit 6dfe513 Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 11:58:00 2023 -0700 gh actions from ubuntu to macos commit 1d1b73a Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 11:57:14 2023 -0700 add jest coverage reporters commit 9a62549 Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 11:50:41 2023 -0700 update jest commit d58b4c6 Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 27 11:48:56 2023 -0700 update jest coverage commit 0da60eb Author: Joe Heffernan <interim17@gmail.com> Date: Mon Jun 26 12:15:10 2023 -0700 ternary -> object, styling names, add href commit b0f81ce Author: Joe Heffernan <interim17@gmail.com> Date: Fri Jun 23 15:17:45 2023 -0700 initial unit test commit ecb0b9a Merge: fb2a54f 918556c Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 21 13:48:15 2023 -0700 Merge branch 'main' into feature/share-time-url commit fb2a54f Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 21 13:11:04 2023 -0700 space share and download buttons commit 0245f77 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 21 13:07:33 2023 -0700 move tooltip commit f929046 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 07:00:08 2023 -0700 remove unused values, clean up commit 04deea2 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:25:29 2023 -0700 remove redundant actions commit ee811e7 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 13:45:47 2023 -0700 removing unused imports commit 9e17781 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 12:52:01 2023 -0700 looping playback and tooltip styling commit 2166dc1 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 07:00:08 2023 -0700 remove unused values, clean up commit 820afca Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:25:29 2023 -0700 remove redundant actions commit ce60a9d Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 13:45:47 2023 -0700 removing unused imports commit 41ea887 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 12:52:01 2023 -0700 looping playback and tooltip styling commit 305955e Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 20 15:48:53 2023 -0700 move tooltip and unessary async commit 6b21353 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 08:06:24 2023 -0700 remove comment commit f794da1 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 14:41:10 2023 -0700 removing isDownloading commit 70db90b Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 14:29:04 2023 -0700 removing styling typo commit 5b516c0 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 11:29:15 2023 -0700 clean up comment commit 8c2ac5e Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 10:36:47 2023 -0700 use viewer getasblob method, bump viewer commit a1dfdb1 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Thu May 18 22:23:10 2023 +0000 use href for direct download if remote file commit b2e1bad Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:56:07 2023 -0700 removing comments commit 8ff2ad8 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:51:47 2023 -0700 disable button during downloading commit 4448920 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:04:22 2023 -0700 cleaning commit 2a7b3d1 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:03:06 2023 -0700 cleanup commit 00fcfb4 Author: Joe Heffernan <interim17@gmail.com> Date: Thu May 4 11:53:55 2023 -0700 styling, adding pipe divider commit dbd6322 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 3 14:04:03 2023 -0700 added download functionality commit 13d0057 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 3 09:15:09 2023 -0700 intial ui components commit 918556c Merge: 0749f1a f995097 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 21 09:12:17 2023 -0700 Merge pull request #422 from simularium/feature/download-trajectory Feature/download trajectory commit f995097 Merge: 39a70ca 0749f1a Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 21 09:09:55 2023 -0700 Merge branch 'main' into feature/download-trajectory commit 39a70ca Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 07:00:08 2023 -0700 remove unused values, clean up commit 8319dc7 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:25:29 2023 -0700 remove redundant actions commit 054e670 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 13:45:47 2023 -0700 removing unused imports commit cec3e9b Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 12:52:01 2023 -0700 looping playback and tooltip styling commit bb10334 Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 20 15:48:53 2023 -0700 move tooltip and unessary async commit 7993889 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 14 15:24:34 2023 -0700 remove redundant action from reducer commit 67a2a63 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 14 15:22:33 2023 -0700 remove blue text class commit 225ebfd Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 14 14:52:42 2023 -0700 shift style rules, add light theme, remove buffer commit 0749f1a Merge: cc135e8 ac22916 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Jun 9 15:58:13 2023 -0700 Merge pull request #417 from simularium/feature/updated-looping-playback looping playback and tooltip styling commit 96eca5c Author: Joe Heffernan <interim17@gmail.com> Date: Fri Jun 9 10:30:15 2023 -0700 clean up commit f2ba682 Author: Joe Heffernan <interim17@gmail.com> Date: Fri Jun 9 10:09:16 2023 -0700 consolidate redundant functions commit 57c1e4e Author: Joe Heffernan <interim17@gmail.com> Date: Fri Jun 9 09:56:47 2023 -0700 move clear and rest params to utils commit b5a9bbe Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 8 17:37:34 2023 -0700 clear old params before setting url commit 8f668d6 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 8 13:54:24 2023 -0700 cleaning commit 7a954ca Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 8 13:52:52 2023 -0700 mapping prop to dispatch commit 8b8aa1b Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 8 10:22:02 2023 -0700 update viewer commit c8bb399 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 08:06:24 2023 -0700 remove comment commit 164a6c0 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 08:02:57 2023 -0700 remove unused imports commit 3a89200 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 08:00:09 2023 -0700 hover styling commit 63013b0 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 07:17:22 2023 -0700 nested ternary -> if/else commit ac22916 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Jun 7 07:00:08 2023 -0700 remove unused values, clean up commit 903c09e Author: Joe Heffernan <interim17@gmail.com> Date: Tue Jun 6 16:25:41 2023 -0700 add util func, move logic trigger to viewer panel Co-authored-by: Megan Riel-Mehan <meganrm@gmail.com> commit c1d6364 Author: Joe Heffernan <interim17@gmail.com> Date: Mon Jun 5 09:09:44 2023 -0700 update viewer version commit 48537b5 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 14:41:10 2023 -0700 removing isDownloading commit e14f332 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 14:29:04 2023 -0700 removing styling typo commit c87f78b Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 11:29:15 2023 -0700 clean up comment commit d2f5691 Author: Joe Heffernan <interim17@gmail.com> Date: Thu Jun 1 10:36:47 2023 -0700 use viewer getasblob method, bump viewer commit 73bba1a Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 31 10:58:46 2023 -0700 update viewer commit e5a1a70 Author: Joe Heffernan <interim17@gmail.com> Date: Tue May 23 15:09:04 2023 -0700 refactor to use displayTimes commit 4391367 Author: Joe Heffernan <interim17@gmail.com> Date: Mon May 22 13:06:31 2023 -0700 truncating decimals in url commit c06702d Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 19 14:53:02 2023 -0700 rename components and clean up functions commit 6a5ed73 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Thu May 18 22:23:10 2023 +0000 use href for direct download if remote file commit 9e50b00 Author: Joe Heffernan <interim17@gmail.com> Date: Thu May 18 13:18:43 2023 -0700 ui components for share time in url commit 12836f5 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:56:07 2023 -0700 removing comments commit d6ebc41 Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 10 14:25:29 2023 -0700 remove redundant actions commit 84b3681 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:51:47 2023 -0700 disable button during downloading commit 6a14428 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:04:22 2023 -0700 cleaning commit 2faf8d2 Author: Joe Heffernan <interim17@gmail.com> Date: Fri May 5 11:03:06 2023 -0700 cleanup commit e318c4d Author: Joe Heffernan <interim17@gmail.com> Date: Thu May 4 11:53:55 2023 -0700 styling, adding pipe divider commit 3538d1f Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 3 14:04:03 2023 -0700 added download functionality commit 57b5c1f Author: Joe Heffernan <interim17@gmail.com> Date: Wed May 3 09:15:09 2023 -0700 intial ui components commit f320abe Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 13:45:47 2023 -0700 removing unused imports commit 0221067 Author: Joe Heffernan <interim17@gmail.com> Date: Wed Apr 26 12:52:01 2023 -0700 looping playback and tooltip styling commit cc135e8 Author: ascibisz <alli.scibisz@alleninstitute.org> Date: Fri Apr 21 13:53:12 2023 -0700 update version for add-to-project action commit ec1b5f0 Author: Megan Riel-Mehan <meganrm@gmail.com> Date: Tue Apr 18 12:13:10 2023 -0700 Update CODEOWNERS commit dbe5b58 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 10 11:07:06 2023 -0700 Bump json5 from 1.0.1 to 1.0.2 (#404) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

interim17 added 4 commits March 8, 2024 09:10

new icon glyph set

a7b8b33

apply icomoon icons with css vars and global styles

360803f

remove unused icons

b9e4b81

remove icon declarations now in icomoon font

a93b1e3

interim17 added the maintenance Code cleanup/refactoring, test coverage, etc. label Mar 8, 2024

interim17 commented Mar 8, 2024

View reviewed changes

interim17 marked this pull request as ready for review March 8, 2024 18:09

interim17 requested a review from a team as a code owner March 8, 2024 18:09

interim17 requested review from meganrm and ShrimpCryptid March 8, 2024 18:09

use var for star icon colors

ab4244f

ShrimpCryptid reviewed Mar 8, 2024

View reviewed changes

src/styles/icons.css Outdated

Copy link

Contributor

ShrimpCryptid Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change!

ShrimpCryptid approved these changes Mar 8, 2024

View reviewed changes

interim17 added 2 commits March 12, 2024 11:38

new icomoon font set

72d4002

Merge branch 'main' into fix/icomoon

7ca5f10

meganrm approved these changes Mar 12, 2024

View reviewed changes

interim17 merged commit e20842b into main Mar 12, 2024
7 checks passed

interim17 deleted the fix/icomoon branch March 12, 2024 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/icomoon #476

Fix/icomoon #476

interim17 commented Mar 8, 2024

interim17 Mar 8, 2024

interim17 Mar 8, 2024

interim17 Mar 8, 2024

interim17 Mar 8, 2024

github-actions bot commented Mar 8, 2024 •

edited

Loading

interim17 Mar 8, 2024 •

edited

Loading

interim17 Mar 8, 2024

ShrimpCryptid Mar 8, 2024

interim17 Mar 8, 2024

ShrimpCryptid Mar 8, 2024

ShrimpCryptid left a comment

meganrm left a comment

Fix/icomoon #476

Fix/icomoon #476

Conversation

interim17 commented Mar 8, 2024

Time to review:

Problem:

Solution:

Other changes:

To review:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 8, 2024 • edited Loading

Coverage report

Test suite run success

interim17 Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShrimpCryptid left a comment

Choose a reason for hiding this comment

meganrm left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 8, 2024 •

edited

Loading

interim17 Mar 8, 2024 •

edited

Loading