Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a default collapsed #397

Merged
merged 2 commits into from
Feb 18, 2023
Merged

add a default collapsed #397

merged 2 commits into from
Feb 18, 2023

Conversation

meganrm
Copy link
Contributor

@meganrm meganrm commented Feb 17, 2023

Problem

On mobile the app is pretty unusable because the panels are open by default and overlap each other.

Blair has QR codes on her poster

Solution

The collapsed state on the side panels is initialized based on the window size. This means that it's only set on load, it's not set as a listeners. So if a user did the strange thing of loading the app on their computer, and then make the browser window tiny, it won't auto close the panels unless they re-load at the smaller size

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

1.npm start
2. make the screen mobile sized and reload
3. the panels should initialize to closed
4. make the screen normal screen sized and reload
5. the panels should initialize to open

Screenshots (optional):

Screen Shot 2023-02-16 at 4 12 25 PM

@meganrm meganrm requested a review from a team as a code owner February 17, 2023 00:12
@meganrm meganrm requested review from toloudis, frasercl and ascibisz and removed request for a team February 17, 2023 00:12
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.3% (+0.03% 🔼)
558/741
🟡 Branches 70.64% 77/109
🔴 Functions 42.61% 75/176
🟡 Lines
73.89% (+0.04% 🔼)
501/678

Test suite run success

90 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from b16a911

@meganrm meganrm requested a review from blairlyons February 17, 2023 00:28
@meganrm
Copy link
Contributor Author

meganrm commented Feb 17, 2023

Feb-16-2023 17-08-21

Copy link
Contributor

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meganrm meganrm merged commit d9167ff into main Feb 18, 2023
@meganrm meganrm deleted the fix/mobile-close-panels branch February 18, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants