Feature/update workflows #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell-animated/simularium-website into feature/update-workflows
…ium-website into feature/update-workflows
meganrm
requested review from
toloudis,
frasercl and
ascibisz
and removed request for
a team
jest coverage report 🧪Total coverage
|
toloudis
reviewed
Sep 19, 2022
gh-pages/index.html
Outdated
| </head> | ||
| <body> | ||
| <a href="https://simularium.github.io/simularium-website/dev">App with viewer at development head</a> | ||
| <a href="https://simularium.github.io/simularium-website/stable">App with latest released stable viewer</a> |
There was a problem hiding this comment.
would relative urls "dev" and "stable" work here?
toloudis
reviewed
Sep 19, 2022
| @@ -1,11 +1,8 @@ | |||
| name: Deploy AWS production | |||
| name: Continuos Integration | |||
toloudis
reviewed
Sep 20, 2022
gh-pages/index.html
Outdated
| </head> | ||
| <body> | ||
| <a href="/dev">App with viewer at development head</a> | ||
| <a href="/stable">App with latest released stable viewer</a> |
There was a problem hiding this comment.
i'm not 100% sure it works with the leading / ... unless you tested it
toloudis
approved these changes
Sep 20, 2022
blairlyons
approved these changes
Sep 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #352
Solution
Using github actions upload and download, I was able to build the app twice with two different builds and then upload them both to the gh-pages branch. I tested this on https://github.com/meganrm/react-redux-github-actions/actions/runs/3085116920 because I couldn't get this action to trigger while it's on a branch.
I also used conditionals to remove the redundant workflow files
Type of change
Please delete options that are not relevant.