Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading from url, was still assuming pure json format #345

Merged
merged 1 commit into from
May 26, 2022

Conversation

toloudis
Copy link
Contributor

Problem

load from url had not been properly updated to match viewer interfaces.
resolves #344

Solution

I just didn't find this code path when making a similar update for drag and drop. Once identified, the fix was to just ensure that the object passed around is an ISimulariumFile instead of a json object.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@toloudis toloudis requested a review from a team as a code owner May 26, 2022 15:57
@toloudis toloudis requested review from meganrm and blairlyons and removed request for a team May 26, 2022 15:57
@github-actions
Copy link

jest coverage report 🧪

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.85% 517/700
🟡 Branches 68.18% 105/154
🔴 Functions 42.61% 75/176
🟡 Lines 73.77% 498/675

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🔴 src/state/trajectory 36.46% 0% 4.34% 36.46%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

@toloudis toloudis merged commit 608e75e into main May 26, 2022
@toloudis toloudis deleted the fix/loadfromurl branch May 26, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load via URL is broken on staging
3 participants