won't show time controls if there is no time range #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrm
requested review from
toloudis and
blairlyons
and removed request for
a team
jest coverage report 🧪Total coverage
|
toloudis
approved these changes
May 13, 2022
toloudis
reviewed
May 13, 2022
| loading={isBuffering} | ||
| isEmpty={status === VIEWER_EMPTY} | ||
| /> | ||
| {firstFrameTime !== lastFrameTime && ( |
There was a problem hiding this comment.
i wonder if there is a better check, like count of number of frames === 1
There was a problem hiding this comment.
yeah, this component doesn't know the total number, and I didn't investigate when/if that gets sent in. I don't see any way this would be wrong when the count would be right though
There was a problem hiding this comment.
it's the opposite case i'd be worried about: when num frames > 1 but each frame has the same frame time (or within floating point equality)
blairlyons
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cellPack files don't need playback controls when they're a single frame
Solution
Only show playback controls if the first time and last time are different
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):
showing a cellpack file with no time bar
