Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align types to standards #99

Merged
merged 10 commits into from
Dec 1, 2022
Merged

Align types to standards #99

merged 10 commits into from
Dec 1, 2022

Conversation

yvgny
Copy link
Contributor

@yvgny yvgny commented Nov 30, 2022

The current types of our implementation, like DIDDocc, do not follow the standards (see did-core, didcomm-messaging).

This PR aims to align them.

Fixes #91.

@yvgny yvgny marked this pull request as ready for review December 1, 2022 08:12
@yvgny yvgny requested a review from dkulic December 1, 2022 08:53
Copy link
Contributor

@dkulic dkulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvgny yvgny merged commit 81fb1b4 into main Dec 1, 2022
@yvgny yvgny deleted the fix/align-types-to-std branch December 1, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for TS is not following standards, specifically DIDDoc
2 participants