You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Give a brief description of the objective of this issue. What needs to be discussed?
The current produced types for TS is not following standards of the spec.
I just touched upon the DIDDoc type and that has false things such as:
/**
* DID URLs of verification methods used for key agreement.
* See https://www.w3.org/TR/did-core/#verification-methods.
*/
key_agreements: Array<string>,
So I dont know how literal to the spec one should be, but the resolved documents will not be of proper attributes if these types are correct.
Why
Explain why you think this issue needs to be addressed and why it should be addressed in this repo.
Because the produced type is not correct to what a did doc should be if you want to work with other libraries.
Success Criteria
Explain what actions or decisions need to be completed to close this issue.
Using a task list here can be helpful to track progress.
Update the production of types to produce proper TS types
Anything else
Include links to any examples, research or code that support this issue.
I dont know how this works with a wasmbinding and the rust magic, but I assume it transpiles the attribute values in the rust code directly to these names. And then I can understand things become a bit wonky.
Maybe one can define in some config somewhere to transpile to the right attributes?
Before submitting:
Add appropriate labels for 'type:' and 'related to:'
Add an assignee if you want to direct this issue at a particular individual
The text was updated successfully, but these errors were encountered:
Hi @vongohren, the main branch is now updated with types aligned to the standards. Let me know if you still find any discrepancies. Once it's stabilized we can issue a new release of the lib too.
What
This should be
id
- https://www.w3.org/TR/did-core/#did-document-propertiesthis should be
keyAgreements
- https://www.w3.org/TR/did-core/#did-document-propertiesSo I dont know how literal to the spec one should be, but the resolved documents will not be of proper attributes if these types are correct.
Why
Because the produced type is not correct to what a did doc should be if you want to work with other libraries.
Success Criteria
Anything else
The text was updated successfully, but these errors were encountered: