-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed range parsing #115
Fixed range parsing #115
Conversation
Hi! These changes look valid to me, nice catch 👍 : ) Sadly the CI doesn't run anymore, which seems not related to your changes. |
I honestly have no idea why it passes in master (https://github.com/dg/sebastianbergmann-diff/actions/runs/4495014297), but it doesn't pass in any other branch (https://github.com/dg/sebastianbergmann-diff/actions/runs/4491522850) |
Should work now after 9f7efbc. |
af0f2de
to
59dd1b4
Compare
Thank you! |
thansk @dg 👍 :) |
One more thing. It's not a bug in the parser. It's just a weird meaning of the numbers 🤯 I haven't found any expanation, just a mention here https://www.artima.com/weblogs/viewpost.jsp?thread=164293
If you want, I'll post a PR to readme. |
That would be appreciated, thanks. |
Fixes two errors when parsing diff files
isset($match['startrange'])
is alwaystrue