Parser: isset($match['startrange']) was always true

Author: dg

src/Parser.php

@@ -74,7 +74,7 @@ private function parseFileDiff(Diff $diff, array $lines): void
         $diffLines = [];
 
         foreach ($lines as $line) {
-            if (preg_match('/^@@\s+-(?P<start>\d+)(?:,\s*(?P<startrange>\d+))?\s+\+(?P<end>\d+)(?:,\s*(?P<endrange>\d+))?\s+@@/', $line, $match)) {
+            if (preg_match('/^@@\s+-(?P<start>\d+)(?:,\s*(?P<startrange>\d+))?\s+\+(?P<end>\d+)(?:,\s*(?P<endrange>\d+))?\s+@@/', $line, $match, PREG_UNMATCHED_AS_NULL)) {
                 $chunk = new Chunk(
                     (int) $match['start'],
                     isset($match['startrange']) ? max(0, (int) $match['startrange']) : 1,

tests/ParserTest.php

@@ -201,6 +201,9 @@ public function testParseWithRange(): void
 --- a/Test.txt
 +++ b/Test.txt
 @@ -49,0 +49,0 @@
+@@ -50 +50 @@
+ A
+-B
 END;
         $diffs = $this->parser->parse($content);
         $this->assertContainsOnlyInstancesOf(Diff::class, $diffs);
@@ -209,13 +212,19 @@ public function testParseWithRange(): void
         $chunks = $diffs[0]->getChunks();
 
         $this->assertContainsOnlyInstancesOf(Chunk::class, $chunks);
-        $this->assertCount(1, $chunks);
+        $this->assertCount(2, $chunks);
 
         $chunk = $chunks[0];
         $this->assertSame(49, $chunk->getStart());
         $this->assertSame(49, $chunk->getEnd());
         $this->assertSame(0, $chunk->getStartRange());
         $this->assertSame(0, $chunk->getEndRange());
+
+        $chunk = $chunks[1];
+        $this->assertSame(50, $chunk->getStart());
+        $this->assertSame(50, $chunk->getEnd());
+        $this->assertSame(1, $chunk->getStartRange());
+        $this->assertSame(1, $chunk->getEndRange());
     }
 
     /**