Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Scala 2.13 can transform Scala 3 code and vice versa #647

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Dec 10, 2024

TODO:

  • update build
    • test locally that artifacts are not broken
  • define 2.13 and 3 test cases
    • case classes
    • case classes with @BeanProperty
    • classes with default values in constructor
    • enums with parameters in any value
    • enums without parameters in any value
    • sealed traits
  • tests 2.13 converting 3 classes and vice versa
    • case classes
    • @BeanProperties as source/target
    • sealed traits to/from enums
    • default values in target type
  • documentation - describe what is possible and what isn't

Updated and fixed version of #475

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (7d29a86) to head (0c86ba2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   86.48%   86.55%   +0.06%     
==========================================
  Files         158      158              
  Lines        6225     6240      +15     
  Branches      559      539      -20     
==========================================
+ Hits         5384     5401      +17     
+ Misses        841      839       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok changed the title Ensure that Scala 2.13 can transform Scala 3 code and vide-versa WIP: Ensure that Scala 2.13 can transform Scala 3 code and vide-versa Dec 10, 2024
@MateuszKubuszok MateuszKubuszok marked this pull request as draft December 10, 2024 12:33
@MateuszKubuszok MateuszKubuszok changed the title WIP: Ensure that Scala 2.13 can transform Scala 3 code and vide-versa Ensure that Scala 2.13 can transform Scala 3 code and vide-versa Dec 11, 2024
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review December 11, 2024 13:10
@MateuszKubuszok MateuszKubuszok changed the title Ensure that Scala 2.13 can transform Scala 3 code and vide-versa Ensure that Scala 2.13 can transform Scala 3 code and vice versa Dec 11, 2024
@MateuszKubuszok MateuszKubuszok merged commit 456fa21 into master Dec 11, 2024
24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the sandwich-tests branch December 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests and then official support for Scala 3 macros handling Scala 2.13 code and vice-versa
1 participant